Skip to content

Commit

Permalink
chore(ci): Remove path filter that runs all integration tests
Browse files Browse the repository at this point in the history
Currently this causes all integration tests to run on common dependabot changes to
`lib/vector-core/Cargo.toml` even though those changes are likely to be very low risk. These tests
also fail due to dependabot not having access to secrets but that is being addressed separately; the
primary argument in this PR is that the tests aren't needed in the PR, just the merge queue, for changes to `Cargo.toml` due to the low risk.

I had originally just wanted to exclude only `lib/vector-core/Cargo.toml` but this wasn't possible
due to a lack of support by the paths-filter action
(dorny/paths-filter#106). Upon reflection, I think it is is unlikely that
core changes will cause integration test failures that don't also cause other test failures so my
proposal is that we just rely on the merge queue to catch that scenario. If we find it to be the
contrary, we can add it back.

Signed-off-by: Jesse Szwedko <jesse.szwedko@datadoghq.com>
  • Loading branch information
jszwedko committed Jul 7, 2023
1 parent 4ef0b17 commit 4770b0f
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions vdev/src/commands/integration/ci_paths.rs
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,8 @@ pub struct Cli {}

impl Cli {
pub fn exec(&self) -> Result<()> {
// changes to vector-core should test all integrations
// placeholder for changes that should run all integration tests
println!("all-int:");
println!("- \"lib/vector-core/**\"");

// paths for each integration are defined in their respective config files.
for (integration, config) in IntegrationTestConfig::collect_all()? {
Expand Down

0 comments on commit 4770b0f

Please sign in to comment.