Skip to content
This repository has been archived by the owner on Jan 5, 2025. It is now read-only.

AB#30325 make app reg an enterprise app #3

Merged
merged 6 commits into from
Apr 12, 2024

Conversation

johncollinson2001
Copy link
Contributor

NOTE - this PR was originally raised by Frances in ADO, and has been recreated here in GH.

NOTE - this PR was originally raised by Frances in ADO, and has been recreated here in GH.
@gaurarpit
Copy link
Contributor

pre-commit hook(s) made changes.
If you are seeing this message in CI, reproduce locally with: `pre-commit run --all-files`.
To run `pre-commit` as part of git workflow, use `pre-commit install`.
All changes made by hooks:
diff --git a/infrastructure/app-registration.tf b/infrastructure/app-registration.tf
index 5b7de12..55d659d 100644
--- a/infrastructure/app-registration.tf
+++ b/infrastructure/app-registration.tf
@@ -74,8 +74,8 @@ resource "azuread_application_pre_authorized" "azcli" {
 }
 
 resource "azuread_service_principal" "app" {
-  client_id                = azuread_application.app.application_id
-  owners                   = var.app_registration_owners
+  client_id = azuread_application.app.application_id
+  owners    = var.app_registration_owners
   tags = [
     "AppServiceIntegratedApp",
     "WindowsAzureActiveDirectoryIntegratedApp",
Error: Process completed with exit code 1.

Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
All tests passing too.

@gaurarpit
Copy link
Contributor

ahh... an accidental push caused anger issues to pre-commit . undoing that.

@gaurarpit
Copy link
Contributor

Life is good again. Merging it in.

@gaurarpit gaurarpit merged commit 358534a into main Apr 12, 2024
2 checks passed
@liammoat liammoat deleted the bugfix/ADO-30325/make-app-reg-an-enterprise-app branch April 12, 2024 20:13
johncollinson2001 pushed a commit that referenced this pull request Apr 23, 2024
This PR introduces the latest version from the upstream GitHub project.

- Add pre-commit exclude (#1)
- Update Swagger Docs generation script to create directory (#2)
- Update Azure.Identity from 1.10.4 with CVE to patched version 1.11.0 (#5)
- AB#30325 make app reg an enterprise app (#3)
- fix: performance of terminology server tests (#6)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants