This repository has been archived by the owner on Jan 5, 2025. It is now read-only.
fix: performance of terminology server tests #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liammoat
changed the title
|
this is a very good catch and fix. thanks. |
gaurarpit
reviewed
Apr 14, 2024
tests/Unit.Tests/Infrastructure/Terminology/FileTerminologyServiceTests.cs
Show resolved
Hide resolved
johncollinson2001
pushed a commit
that referenced
this pull request
Apr 23, 2024
This PR introduces the latest version from the upstream GitHub project. - Add pre-commit exclude (#1) - Update Swagger Docs generation script to create directory (#2) - Update Azure.Identity from 1.10.4 with CVE to patched version 1.11.0 (#5) - AB#30325 make app reg an enterprise app (#3) - fix: performance of terminology server tests (#6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Dorset downstream project, the Unit Tests fail to execute in a timely fashion. This is due to the
IMemoryCachemock - and it's poor performance when the Snomed codes are populated.This PR replaces the unnecessary mock, and uses a newly instantiated
MemoryCachefor each test execution.With a full Snomed dataset, the Unit Tests now complete in a more reasonable time window. As seen here:
Note: I have also updated the test to use a Snomed code from an example provided in this NHS article.