Skip to content

Commit

Permalink
Revert stderr.decode("utf-8") that was landed in nodejs#1937
Browse files Browse the repository at this point in the history
  • Loading branch information
cclauss authored Oct 30, 2019
1 parent 15a0ded commit cea42a4
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion gyp/pylib/gyp/input.py
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,9 @@ def ExpandVariables(input, phase, variables, build_file):
p_stdout, p_stderr = p.communicate('')

if p.wait() != 0 or p_stderr:
sys.stderr.write(p_stderr.decode('utf-8'))
sys.stderr.write(p_stderr)
# Simulate check_call behavior, since check_call only exists
# in python 2.5 and later.
raise GypError("Call to '%s' returned exit status %d while in %s." %
(contents, p.returncode, build_file))
replacement = p_stdout.rstrip()
Expand Down

0 comments on commit cea42a4

Please sign in to comment.