Finish decode stdout on Python 3 #1937
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2019
richardlau
approved these changes
Oct 25, 2019
gengjiawen
approved these changes
Oct 27, 2019
4 tasks
rvagg
pushed a commit
that referenced
this pull request
Oct 27, 2019
PR-URL: #1937 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
cclauss
added a commit
to dothebart/node-gyp
that referenced
this pull request
Oct 30, 2019
chrmoritz
added a commit
to chrmoritz/node
that referenced
this pull request
Nov 5, 2019
original commit: nodejs/node-gyp@a48f09b Refs: nodejs/node-gyp#1937 Co-Authored-By: Christian Clauss <cclauss@me.com>
rvagg
pushed a commit
that referenced
this pull request
Nov 18, 2019
PR-URL: #1937 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1943
Like #1890 and #1894 but for all remaining instances of popen.communicate() in this repo. This conditionally decodes the bytes that come from popen.communicate() into str for proper handling in Python 3.
grep -r communicate .and ensure all stdout and stderr instances are decoded on Python 3.Checklist
npm install && npm testpassesDescription of change