more decode stdout on Python 3 #1894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
approved these changes
Sep 26, 2019
sam-github
approved these changes
Sep 26, 2019
sam-github
approved these changes
Sep 26, 2019
rvagg
pushed a commit
that referenced
this pull request
Sep 27, 2019
PR-URL: #1894 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Sep 27, 2019
PR-URL: #1894 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
|
landed in 67dec14 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm install && npm testpassesDescription of change
Python 2 does not make a distinction between bytes and str but Python 3 does. When we make calls to subprocess.Popen() on Python 3 we should stdout.decode("utf8") before performing string manipulations on it.
Like #1890
Addresses the code review comments at #1893 (review)