Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release proposal: node-gyp@6.0.1 #1935

Closed
wants to merge 1 commit into from
Closed

Conversation

rvagg
Copy link
Member

@rvagg rvagg commented Oct 24, 2019

Nothing huge, but we could clear some backlog. The dependencies update might be cause for concern if someone really cares about what dependencies are pulled in, there might also be a usecase we haven't tested for that breaks with this change. On the surface it's hard to make a case for anything other than semver-patch though I think.

  • [1b11be63cc] - gyp: python3 fixes: utf8 decode, use of 'None' in eval (Wilfried Goesgens) #1925
  • [c0282daa48] - gyp: iteritems() -> items() in compile_commands_json.py (cclauss) #1947
  • [d8e09a1b6a] - gyp: make cmake python3 compatible (gengjiawen) #1944
  • [9c0f3404f0] - gyp: fix TypeError in XcodeVersion() (Christian Clauss) #1939
  • [bb2eb72a3f] - gyp: finish decode stdout on Python 3 (Christian Clauss) #1937
  • [f0693413d9] - src,win: allow 403 errors for arm64 node.lib (Richard Lau) #1934
  • [c60c22de58] - deps: update deps to roughly match current npm@6 (Rod Vagg) #1920
  • [b91718eefc] - test: upgrade Linux Travis CI to Python 3.8 (Christian Clauss) #1923
  • [3538a317b6] - doc: adjustments to the README.md for new users (Dan Pike) #1919
  • [4fff8458c0] - travis: ignore failed brew upgrade npm, update xcode (Christian Clauss) #1932
  • [60e4488f08] - build: avoid bare exceptions in xcode_emulation.py (Christian Clauss) #1932
  • [032db2a2d0] - lib,install: always download SHA sums on Windows (Sam Hughes) #1926
  • [5a83630c33] - travis: add Windows + Python 3.8 to the mix (Rod Vagg) #1921

@cclauss
Copy link
Contributor

cclauss commented Oct 24, 2019

I believe that we should get #1937 in here.

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would advocate that we add:

@rvagg
Copy link
Member Author

rvagg commented Oct 31, 2019

Updated OP with latest CHANGELOG. I'll put #1940 in here too unless there's further objections in there.

So last call on objections, amendments, whatever else, otherwise I'll publish this within 24 hours.

PR-URL: #1935
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@gengjiawen
Copy link
Member

Is there a plan to sync those change to nodejs\node ?

Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready but #1940 would be a nice addition.

@rvagg rvagg closed this Nov 1, 2019
@rvagg rvagg deleted the rvagg/v6.0.1-proposal branch November 1, 2019 10:16
@rvagg
Copy link
Member Author

rvagg commented Nov 1, 2019

published

rvagg added a commit that referenced this pull request Nov 1, 2019
PR-URL: #1935
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Christian Clauss <cclauss@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants