Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aspnet/core/security/authentication/social/ for 2.0 #3862

Closed
Rick-Anderson opened this issue Aug 1, 2017 · 2 comments
Closed

aspnet/core/security/authentication/social/ for 2.0 #3862

Rick-Anderson opened this issue Aug 1, 2017 · 2 comments
Labels
Pri0 Urgent priority
Milestone
2017-2.0 RTW

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Aug 1, 2017 •
edited
Loading

@01binary - this from @timheuer

https://docs.microsoft.com/en-us/aspnet/core/security/authentication/social/google-logins
i'm following this doc and after adding the middleware package, the api AddGoogleAuthentication (and the Microsoft one) are not available
I think it should be app.Use*

MSA auth would fails
-- end of Tim --

Can we mark off the steps that require ASP.NET Core 2.0? Did we lose the steps for 1.x?

I think Tim has Google working but not MSA. Any trouble shooting tips?
@Rick-Anderson Rick-Anderson added the Pri0 Urgent priority label Aug 1, 2017
@Rick-Anderson Rick-Anderson added this to the 2017-2.0 RTW milestone Aug 1, 2017
@01binary
Copy link
Contributor

01binary commented Aug 1, 2017

We can add a tabbed container with code snippets for 1.x and 2.x. I dropped 1.x steps because they constitute breaking changes. The 1.x snippets can be recovered from previous version to add them back.

@01binary
Copy link
Contributor

01binary commented Aug 2, 2017

I think Tim has Google working but not MSA. Any trouble shooting tips? @RickAndMSFT

I verified MSA for 2.0 at the time of writing that topic. Does @timheuer want to start an email chain or post here to describe his experience? The step where it fails is important. Did he look at Troubleshooting section?

scottaddie pushed a commit that referenced this issue Aug 4, 2017
@01binary @scottaddie
Fixes #3862 Support SDK 1.0 in 2.0 topics (revert and fix) (#3874)
d0ccaee 
* #3753 Update social logins index

* #3753 Update facebook logins

* #3753 Update Google logins

* #3753 Update Twitter logins

* #3753 Update Microsoft logins

* #3753 Combine social and local login accounts screenshot update

* #3753 Fix app name in screenshot

* #3753 QA pass

* #3753 Put borders on screenshots to replace shadows

* Update facebook-logins.md

Minor clean up - remove future tense. Split up long sentences to help software translators.

* Update facebook-logins.md

* Update google-logins.md

* Update index.md

* #3753 Fix missing anchor

* Merge with origin

* #3862 Social snippets by SDK vesion

* #3862 Fix snippets for RTM 2.0 and italicise

* #3862 dotnet CLI > .NET Core CLI

* #3862 Fix snippets for RTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Pri0 Urgent priority
Projects
None yet
Milestone
2017-2.0 RTW
Development

No branches or pull requests
2 participants
@Rick-Anderson @01binary