Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.0 update aspnet/core/security/authentication/social/ for 2.0 #3753

Closed
7 tasks
Rick-Anderson opened this issue Jul 17, 2017 · 10 comments
Closed
7 tasks

2.0 update aspnet/core/security/authentication/social/ for 2.0 #3753

Rick-Anderson opened this issue Jul 17, 2017 · 10 comments
Labels
Milestone

Comments

@Rick-Anderson
Copy link
Contributor

Rick-Anderson commented Jul 17, 2017

15:55 into 7-17 recording.

@Rick-Anderson
Copy link
Contributor Author

@01binary let me know if you can help update these for VS 2017/ASP.NET Core 2.x
I can do all the MD work if you want to provide the updated steps.

@01binary
Copy link
Contributor

I think I will have some time during the next couple of weeks.

@Rick-Anderson
Copy link
Contributor Author

@01binary put yourself as lead author and me second. Drop Pranav Rastogi

@01binary
Copy link
Contributor

01binary commented Jul 22, 2017

Setting up my environment with Visual Studio 2017 Preview version 15.3 and .NET Core 2.0 Preview 2 unless you specify otherwise.

[EDIT]

It looks like Social Logins section that needs the most attention is enabling SSL. I see that you already have two topics that deal with the subject:

  1. Setting up SSL in ASP.net Core project
    https://docs.microsoft.com/en-us/aspnet/core/security/https

  2. Enforcing SSL in ASP.net Core project
    https://docs.microsoft.com/en-us/aspnet/core/security/enforcing-ssl

It looks like #2 duplicates parts of #1, so before I can properly update Social Logins topics (at least in a way that provides measurable improvement for customers) I need to edit #1 to include any missing parts described in #2 and delete #2. Probably some cleanup as well to make the steps easier to follow for VS2017 users on Windows and VSCode users on Mac. Then a second pull request to have social logins reference the updated #1 topic. Hopefully someone from your team can take over supporting the updated SSL topic because I barely managed to setup SSL myself.

@Rick-Anderson
Copy link
Contributor Author

I can do the SSL work. For Visual Studio 2017 preview 3 and higher, the individual user accounts tutorial automatically set the URL to HTTPS.

Install latest .NET Core 2.0 SDK from https://github.com/dotnet/cli/tree/release/2.0.0
Note that ASP.NET Core 2.0 is a separate install from VS. You have to separately download and install the .NET Core 2.0 SDK to get the ASP.NET Core 2.0 bits.

@Rick-Anderson
Copy link
Contributor Author

@01binary also list yourself as lead author and drop the other co-authors.

@01binary
Copy link
Contributor

This tutorial demonstrates how to build an ASP.NET Core app that enables users to log in using OAuth 2.0/1.0a

Sounds like 1.0a should be removed because 1.0 stack is no longer supported? Reference: aspnet/Security#1310

@01binary
Copy link
Contributor

Updated index and facebook so far

https://github.com/01binary/Docs/blob/master/aspnetcore/security/authentication/social/index.md
https://github.com/01binary/Docs/blob/master/aspnetcore/security/authentication/social/facebook-logins.md

Going to create a PR when all done

@01binary
Copy link
Contributor

In the course of updating the content, I found that complaints about steps no longer applying for Facebook and Google were due to skipped steps while following the tutorials. I will add more screenshots to increase screen space taken by some important steps, making it less likely for someone to skip a single-sentence bullet point.

Many other complaints were about the right place to add social providers, which no longer applies (AddIdentity can be called before or after, doesn't matter, and UseMvc is now in a completely different place so you can't accidentally setup providers after it). I am adding a Troubleshooting section to each social provider topic to take care of the rest.

@01binary
Copy link
Contributor

01binary commented Jul 29, 2017

Combine social and local login accounts (only the last section)

I don't know what this means but I went through the steps and everything looks accurate in that last section. I updated the screenshot to match the new project template, but differences were minimal.

Rick-Anderson pushed a commit that referenced this issue Aug 1, 2017
#3848)

* #3753 Update social logins index

* #3753 Update facebook logins

* #3753 Update Google logins

* #3753 Update Twitter logins

* #3753 Update Microsoft logins

* #3753 Combine social and local login accounts screenshot update

* #3753 Fix app name in screenshot

* #3753 QA pass

* #3753 Put borders on screenshots to replace shadows

* Update facebook-logins.md

Minor clean up - remove future tense. Split up long sentences to help software translators.

* Update facebook-logins.md

* Update google-logins.md

* Update index.md

* #3753 Fix missing anchor
Rick-Anderson pushed a commit that referenced this issue Aug 2, 2017
* #3753 Update social logins index

* #3753 Update facebook logins

* #3753 Update Google logins

* #3753 Update Twitter logins

* #3753 Update Microsoft logins

* #3753 Combine social and local login accounts screenshot update

* #3753 Fix app name in screenshot

* #3753 QA pass

* #3753 Put borders on screenshots to replace shadows

* Update facebook-logins.md

Minor clean up - remove future tense. Split up long sentences to help software translators.

* Update facebook-logins.md

* Update google-logins.md

* Update index.md

* #3753 Fix missing anchor

* Merge with origin

* #3862 Social snippets by SDK vesion
scottaddie pushed a commit that referenced this issue Aug 4, 2017
* #3753 Update social logins index

* #3753 Update facebook logins

* #3753 Update Google logins

* #3753 Update Twitter logins

* #3753 Update Microsoft logins

* #3753 Combine social and local login accounts screenshot update

* #3753 Fix app name in screenshot

* #3753 QA pass

* #3753 Put borders on screenshots to replace shadows

* Update facebook-logins.md

Minor clean up - remove future tense. Split up long sentences to help software translators.

* Update facebook-logins.md

* Update google-logins.md

* Update index.md

* #3753 Fix missing anchor

* Merge with origin

* #3862 Social snippets by SDK vesion

* #3862 Fix snippets for RTM 2.0 and italicise

* #3862 dotnet CLI > .NET Core CLI

* #3862 Fix snippets for RTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants