Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3753 update aspnet/core/security/authentication/social/ for 2.0 #3848

Merged
merged 14 commits into from
Aug 1, 2017
Merged

Conversation

01binary
Copy link
Contributor

@01binary 01binary commented Jul 29, 2017

Fixes #3753 update aspnet/core/security/authentication/social/ for 2.0.

  • Update provider steps
  • Update ASP.NET Core code snippets
  • Replace complex inline sections with references to separately maintained topics that would do a better job
  • Update screenshots (shadows replaced with borders to handle light/dark theme switch)
  • Expect QA/wording/markdown pass from @RickAndMSFT
  • All steps verified as actually working but could use a light QA pass from someone intimately familiar with social provider configuration in places where technical details are described

@dnfclas
Copy link

dnfclas commented Jul 29, 2017

@01binary,
Thanks for having already signed the Contribution License Agreement. Your agreement was validated by .NET Foundation. We will now review your pull request.
Thanks,
.NET Foundation Pull Request Bot

Minor clean up - remove future tense. Split up long sentences to help software translators.
@Rick-Anderson
Copy link
Contributor

@01binary looks fantastic. Can you take a quick look at my commits to make sure I didn't break anything?

@01binary
Copy link
Contributor Author

01binary commented Aug 1, 2017

I think I missed something in the markdown:

html.ValidateBookmark](security/authentication/social/google-logins.md#L125)Illegal link: [earlier on this page](#enable-googleplus) -- missing bookmark. The file security/authentication/social/google-logins.md doesn't contain a bookmark named enable-googleplus.

Looks good other than that.

@01binary
Copy link
Contributor Author

01binary commented Aug 1, 2017

On the Google provider page, all the Notes are broken. All other pages seem to have them working.

[EDIT]

I will leave this one to you because the intention is not clear. If you like making notes with ">" and "[!NOTE]" on the first line, then Google can be updated to fix these missing tokens on 87-95 and 105 in google-logins.md

@Rick-Anderson
Copy link
Contributor

@01binary The internal build looks great. I removed a bunch of the obtrusive [!NOTE] > markup and replaced it by regular text.

@Rick-Anderson Rick-Anderson merged commit 07aedb1 into dotnet:master Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants