-
Notifications
You must be signed in to change notification settings - Fork 25.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #3753 update aspnet/core/security/authentication/social/ for 2.0 #3848
Conversation
@01binary, |
Minor clean up - remove future tense. Split up long sentences to help software translators.
@01binary looks fantastic. Can you take a quick look at my commits to make sure I didn't break anything? |
I think I missed something in the markdown:
Looks good other than that. |
On the Google provider page, all the Notes are broken. All other pages seem to have them working. [EDIT] I will leave this one to you because the intention is not clear. If you like making notes with ">" and "[!NOTE]" on the first line, then Google can be updated to fix these missing tokens on |
@01binary The internal build looks great. I removed a bunch of the obtrusive [!NOTE] > markup and replaced it by regular text. |
Fixes #3753 update aspnet/core/security/authentication/social/ for 2.0.