Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ANCM requestTimeout property to remove 'requestTimeout must be specified in whole minutes' #5264

Closed
jkotalik opened this issue Jan 25, 2018 · 4 comments
Assignees
Labels

Comments

@jkotalik
Copy link
Contributor

The requestTimeout in the aspnetcore_schema will be updated to allow a requestTimeout to be specified in seconds. https://github.com/aspnet/Docs/blob/313486d76f89ceac7af9b8c0769f72d1b224d4ca/aspnetcore/host-and-deploy/aspnet-core-module.md can now remove the note about only allowing whole minutes.
cc/ @shirhatti

@jkotalik
Copy link
Contributor Author

This would be for 2.1.

@scottaddie
Copy link
Member

@jkotalik Will this schema change apply ONLY to 2.1 and up? I'm wondering if we should state that the current note applies to all versions prior to 2.1. Thoughts?

@scottaddie scottaddie self-assigned this Jan 25, 2018
@scottaddie scottaddie added the 2.1 label Jan 25, 2018
@shirhatti
Copy link
Contributor

Schema is a global singleton. As long as you've installed a newer ANCM (the one that will ship with 2.1) you'll get the fix, regardless of whether you continue to use an older version of ASP.NET Core.

@guardrex
Copy link
Collaborator

guardrex commented Feb 8, 2018

@Rick-Anderson Would u like to put me on this one? It's right up my alley.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants