Enhance attribute table #8943
Enhance attribute table #8943
Conversation
| @@ -153,11 +153,12 @@ See [Sub-application configuration](xref:host-and-deploy/iis/index#sub-applicati | |||
| | `disableStartUpErrorPage` | <p>Optional Boolean attribute.</p><p>If true, the **502.5 - Process Failure** page is suppressed, and the 502 status code page configured in the *web.config* takes precedence.</p> | `false` | | |||
| | `forwardWindowsAuthToken` | <p>Optional Boolean attribute.</p><p>If true, the token is forwarded to the child process listening on %ASPNETCORE_PORT% as a header 'MS-ASPNETCORE-WINAUTHTOKEN' per request. It's the responsibility of that process to call CloseHandle on this token per request.</p> | `true` | | |||
| | `hostingModel` | <p>Optional string attribute.</p><p>Specifies the hosting model as in-process (`inprocess`) or out-of-process (`outofprocess`).</p> | `outofprocess` | | |||
| | `processesPerApplication` | <p>Optional integer attribute.</p><p>Specifies the number of instances of the process specified in the **processPath** setting that can be spun up per app.</p> | Default: `1`<br>Min: `1`<br>Max: `100` | | |||
There was a problem hiding this comment.
@shirhatti do we even support this?
Also for inprocess processesPerApplication is limited to 1.
There was a problem hiding this comment.
It's a holdover from the HttpPlatformHandler days that unfortunately we can't remove because schema.
There was a problem hiding this comment.
@guardrex Can we add a note saying this is obsoleted and we strongly discourage use of this?
| | `requestTimeout` | <p>Optional timespan attribute.</p><p>Specifies the duration for which the ASP.NET Core Module waits for a response from the process listening on %ASPNETCORE_PORT%.</p><p>In versions of the ASP.NET Core Module that shipped with the release of ASP.NET Core 2.1 or later, the `requestTimeout` is specified in hours, minutes, and seconds.</p><p>Doesn't apply to in-process hosting. For in-process hosting, the module waits for the app to process the request.</p> | `00:02:00` | | ||
| | `shutdownTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to gracefully shutdown when the *app_offline.htm* file is detected.</p> | `10` | | ||
| | `startupTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to start a process listening on the port. If this time limit is exceeded, the module kills the process. The module attempts to relaunch the process when it receives a new request and continues to attempt to restart the process on subsequent incoming requests unless the app fails to start **rapidFailsPerMinute** number of times in the last rolling minute.</p> | `120` | | ||
| | `rapidFailsPerMinute` | <p>Optional integer attribute.</p><p>Specifies the number of times the process specified in **processPath** is allowed to crash per minute. If this limit is exceeded, the module stops launching the process for the remainder of the minute.</p> | Default: `10`<br>Min: `0`<br>Max: `100` | |
There was a problem hiding this comment.
We may need to split options between inproc/out of proc. rapidFailsPerMinute isn't supported for inproc.
There was a problem hiding this comment.
I'd prefer to note these cases in the description if possible since so many of the settings apply to both.
There was a problem hiding this comment.
There was a problem hiding this comment.
aspnetcore_schema_v2.xml is used by both inproc and outofproc.
| | `shutdownTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to gracefully shutdown when the *app_offline.htm* file is detected.</p> | `10` | | ||
| | `startupTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to start a process listening on the port. If this time limit is exceeded, the module kills the process. The module attempts to relaunch the process when it receives a new request and continues to attempt to restart the process on subsequent incoming requests unless the app fails to start **rapidFailsPerMinute** number of times in the last rolling minute.</p> | `120` | | ||
| | `rapidFailsPerMinute` | <p>Optional integer attribute.</p><p>Specifies the number of times the process specified in **processPath** is allowed to crash per minute. If this limit is exceeded, the module stops launching the process for the remainder of the minute.</p> | Default: `10`<br>Min: `0`<br>Max: `100` | | ||
| | `requestTimeout` | <p>Optional timespan attribute.</p><p>Specifies the duration for which the ASP.NET Core Module waits for a response from the process listening on %ASPNETCORE_PORT%.</p><p>In versions of the ASP.NET Core Module that shipped with the release of ASP.NET Core 2.1 or later, the `requestTimeout` is specified in hours, minutes, and seconds.</p> | Default: `00:02:00`<br>Min: `00:00:00`<br>Max: `360:00:00` | |
There was a problem hiding this comment.
This should be ASP.NET Core 2.2.
There was a problem hiding this comment.
U sure ..... see: #5264
There was a problem hiding this comment.
This is a tricky one. At the time of 2.1 releasing, this wasn't the case because we punted inproc support to 2.2. However, now that we have started updating ANCM inside of the hosting bundle, the schema has been updated. I think the schema was updated in either 2.1.4 or 2.1.5, would need to test and verify.
Either way, I think we should mention an ANCM dll version here rather than an AspNetCore version. The dll version would be 12.1.x.x
|
Anything else? ........... before I get flattened by a hurricane??!! 🏃😨 |
Fixes #8659
Internal Review Topic
processesPerApplication.Head-check on
requestTimeout... is the max timeout 360 hours (360:00:00)?