React to ANCM requestTimeout change for 2.1 #5949
Conversation
| | `shutdownTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to gracefully shutdown when the *app_offline.htm* file is detected.</p> | `10` | | ||
| | `startupTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to start a process listening on the port. If this time limit is exceeded, the module kills the process. The module attempts to relaunch the process when it receives a new request and continues to attempt to restart the process on subsequent incoming requests unless the app fails to start **rapidFailsPerMinute** number of times in the last rolling minute.</p> | `120` | | ||
| | `stdoutLogEnabled` | <p>Optional Boolean attribute.</p><p>If true, **stdout** and **stderr** for the process specified in **processPath** are redirected to the file specified in **stdoutLogFile**.</p> | `false` | | ||
| | `stdoutLogFile` | <p>Optional string attribute.</p><p>Specifies the relative or absolute file path for which **stdout** and **stderr** from the process specified in **processPath** are logged. Relative paths are relative to the root of the site. Any path starting with `.` are relative to the site root and all other paths are treated as absolute paths. Any folders provided in the path must exist in order for the module to create the log file. Using underscore delimiters, a timestamp, process ID, and file extension (*.log*) are added to the last segment of the **stdoutLogFile** path. If `.\logs\stdout` is supplied as a value, an example stdout log is saved as *stdout_20180205194132_1934.log* in the *logs* folder when saved on 2/5/2018 at 19:41:32 with a process ID of 1934.</p> | `aspnetcore-stdout` | | ||
| ::: moniker-end | ||
| ::: moniker range=">= aspnetcore-2.1" | ||
| [!INCLUDE[](~/includes/2.1.md)] |
There was a problem hiding this comment.
Any way to minimize the repetition here?
There was a problem hiding this comment.
How do you mean ... the moniker ranges ... no can do unfortunately. They don't work inside table cells AFAIK.
There was a problem hiding this comment.
Yeah that's what I meant.
There was a problem hiding this comment.
Their custom bits (e.g., tab controls, markdown lists, code blocks) blow up 💥 inside table cells. 😢 Some of it we can hack, but this is one that I don't think we can work around.
There was a problem hiding this comment.
@Rick-Anderson @scottaddie Do you have any info? ... we can't break out by table row, can we?
There was a problem hiding this comment.
::: moniker range="moniker-range-expression"
Versioned Content
::: moniker-endA versioned zones starts with ::: moniker on a new line and specifies a range property, the value of which is a valid moniker range. The zone ends with ::: moniker-end, on its own line. All content between these two markers applies to the versions matched by the range expression.
Limitations of Zones
- You can use includes inside of a zone, along with any other standard Markdown or Docs-specific Markdown extensions.
- You can use a zone inside of other constructs, like a blockquote or note.
- You cannot use a
monikerzone inside of anothermonikerzone. Nesting is not permitted.
There was a problem hiding this comment.
... so they don't really say explicitly if we can inject them into a table. Has it been tested? ... I can test it on this PR if you want.
| Col1 | Col2 |
| ---- | ---- |
| Val1 | Val2 |
::: moniker range="<= aspnetcore-1.1"
| Val1 | Val2 |
::: moniker-end
::: moniker range=">= aspnetcore-2.0"
| Val1 | Val2 |
::: moniker-end
| Val1 | Val2 |
There was a problem hiding this comment.
@guardrex try that. Currently the entire table is missing when I select 2.0
|
@Rick-Anderson Try it now (that didn't throw a build error) ... Internal Review Topic ... it's the WRT it not showing for 2.0 before ... rookie first-timer mistake. I know why it was broken; so if we end up going back to my original two-table approach, it should work. |
|
@guardrex breaks table rendering. I think I'll squash/merge and open a bug.
|
|
@guardrex can you move he |
|
@guardrex I think it's OK that it breaks the table rendering for now - especially if you move it to the bottom of the table. |
|
I'd prefer not to do it based on aesthetics. Why not just two tables (I fixed the earlier 2.0 problem)? Internal Review Topic |
|
I'm thinking they can fix the bug fairly quickly. If not, use 2 tables. |
|
... also my table is alphabetical. It would upset the world order ... Earth may fly out of its orbit into the Sun! I wouldn't want the deaths of billions of humans on my hands. 😀 |
|
I reverted it ... see if it works now. |
| | `shutdownTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to gracefully shutdown when the *app_offline.htm* file is detected.</p> | `10` | | ||
| | `startupTimeLimit` | <p>Optional integer attribute.</p><p>Duration in seconds that the module waits for the executable to start a process listening on the port. If this time limit is exceeded, the module kills the process. The module attempts to relaunch the process when it receives a new request and continues to attempt to restart the process on subsequent incoming requests unless the app fails to start **rapidFailsPerMinute** number of times in the last rolling minute.</p> | `120` | | ||
| | `stdoutLogEnabled` | <p>Optional Boolean attribute.</p><p>If true, **stdout** and **stderr** for the process specified in **processPath** are redirected to the file specified in **stdoutLogFile**.</p> | `false` | | ||
| | `stdoutLogFile` | <p>Optional string attribute.</p><p>Specifies the relative or absolute file path for which **stdout** and **stderr** from the process specified in **processPath** are logged. Relative paths are relative to the root of the site. Any path starting with `.` are relative to the site root and all other paths are treated as absolute paths. Any folders provided in the path must exist in order for the module to create the log file. Using underscore delimiters, a timestamp, process ID, and file extension (*.log*) are added to the last segment of the **stdoutLogFile** path. If `.\logs\stdout` is supplied as a value, an example stdout log is saved as *stdout_20180205194132_1934.log* in the *logs* folder when saved on 2/5/2018 at 19:41:32 with a process ID of 1934.</p> | `aspnetcore-stdout` | | ||
| ::: moniker-end | ||
| ::: moniker range=">= aspnetcore-2.1" | ||
| [!INCLUDE[](~/includes/2.1.md)] |
Fixes #5264
Internal Review Topic
In the <=2.0 and >=2.1 rendered table content, you only need to look at the
requestTimeoutrow Description column content.