Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Razor Components: Get started topic update #10780

Merged
merged 3 commits into from
Feb 4, 2019
Merged

Conversation

guardrex
Copy link
Collaborator

@guardrex guardrex commented Feb 3, 2019

Fixes #10765

Updates the Get started topic to go with the RC model.

The only prob is VS for Mac. I have the SDK on the iMac working now. 🎉

References:

Note on VSC: We can't count on VSC producing the tasks.json and launch.json files for us given that the template is a solution with two project inside of it. VSC won't do that for us in this scenario. Therefore, I instruct the dev on how to create those two files in the right spot. Providing the files has the added advantage of explicitly setting the TFM+assembly in the file ... cut-'n-paste ... run it ... 🎤 drop & Done!

aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
@guardrex
Copy link
Collaborator Author

guardrex commented Feb 4, 2019

@danroth27 Updates made. I commented out the VSCode and VS4Mac tabs.

Copy link
Member

@danroth27 danroth27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should track updating this topic for Preview3 when the Razor Components template becomes one project.

@guardrex
Copy link
Collaborator Author

guardrex commented Feb 4, 2019

I added columns to the topic review tracking issue to make sure that these all get hit for Preview 2 and 3 ...

#10717

aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
aspnetcore/razor-components/get-started.md Outdated Show resolved Hide resolved
So much for colloquial style. 😄 lol (See what I have to go thru here, Dan. lol)

Co-Authored-By: guardrex <1622880+guardrex@users.noreply.github.com>
@guardrex
Copy link
Collaborator Author

guardrex commented Feb 4, 2019

Localization ... they wouldn't be impressed with "congrats." lol

@scottaddie scottaddie merged commit fb7517d into master Feb 4, 2019
@delete-merged-branch delete-merged-branch bot deleted the guardrex/rc-get-started branch February 4, 2019 22:11
@guardrex guardrex mentioned this pull request Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants