Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update live with current master #7989

Closed
wants to merge 14 commits into from
Closed

Update live with current master #7989

wants to merge 14 commits into from

Conversation

scottaddie
Copy link
Member

No description provided.

Rick-Anderson and others added 13 commits August 3, 2018 17:08
* Add guidance on HttpClient disposal

* React to feedback

* React to feedback
Hello, @scottcate,
Localization team has reported source content issue that causes localized version to have broken/different format compared to en-us version.  
"There's an extra asterisk that's breaking the Note code. In case the italics must be conserved, we suggest to start them on line 53."
Please review and merge the proposed file change to fix to target versions. If you make related fix in another PR  then share your PR number so we can confirm and close this PR.
Many thanks in advance.
@Rick-Anderson
Copy link
Contributor

@scottaddie hold merging this for 5 minutes

@Rick-Anderson
Copy link
Contributor

I'm about to S&M #7930 and want to get it live. I can merge this when it validates.

* WIP:Update Intro to Identity to 2.1

* work

* work

* work

* work

* work

* work

* work

* minor corrections

* more typos

* react to feedback
@Rick-Anderson
Copy link
Contributor

@scottaddie even after closing/opening, it wouldn't pick up #7930
It picked up WIP from one of the commits and I couldn't get rid of that. Had to create #7990 to pick up #7930

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants