Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Intro to Identity to 2.1 #7930

Merged
merged 11 commits into from
Aug 8, 2018
Merged

Update Intro to Identity to 2.1 #7930

merged 11 commits into from
Aug 8, 2018

Conversation

Rick-Anderson
Copy link
Contributor

@Rick-Anderson Rick-Anderson commented Aug 2, 2018

Fixes #7131 Fixes #7823 Fixes #6439
Fixes #7982 Fixes #6624 Fixes #7837
Internal review URL

@Rick-Anderson Rick-Anderson removed the WIP label Aug 8, 2018
@Rick-Anderson Rick-Anderson changed the title WIP:Update Intro to Identity to 2.1 Update Intro to Identity to 2.1 Aug 8, 2018
@Rick-Anderson Rick-Anderson requested a review from tdykstra August 8, 2018 01:57
@Rick-Anderson
Copy link
Contributor Author

@tdykstra if a bunch of typo's need fixen, edit the file (in the browser) and create a new commit. If I'm 95% likely to accept your changes, commit to this branch, otherwise create a new PR.

Copy link
Contributor

@tdykstra tdykstra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; a few suggestions inline, plus two general observations:

  • We are supposed to be using "sign in" rather than "log in", though that's problematic where the UI still has "log in".
  • "article" is now recommended in place of "topic"


If using the .NET Core CLI, create the new project using `dotnet new mvc --auth Individual`. This command creates a new project with the same Identity template code Visual Studio creates.
::: moniker range=">= aspnetcore-2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual versioning is not working well for 1.0. Configure and ConfigureServices snippets are duplicated, and some h2 headings have no content. Is it feasible to just set this up so it goes to 2.0 if you try for 1.0?

@@ -1,66 +1,82 @@
---
title: Introduction to Identity on ASP.NET Core
author: rick-anderson
description: Use Identity with an ASP.NET Core app. Includes, Setting password requirements (RequireDigit,RequiredLength,RequiredUniqueChars and more).
description: Use Identity with an ASP.NET Core app. Learn how to set password requirements (RequireDigit, RequiredLength, RequiredUniqueChars, and more).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I modified a grammar glitch here, but the article doesn't actually cover pw requirements -- that section just links out to another article. I'd say drop the pw req text here.


## Setting password strength

See [Configuration](#pw) for a sample that sets the minimum password requirements.

## Next Steps

* [Configure Identity](xref:security/authentication/identity-configuration)
* <xref:security/authorization/secure-data>
Copy link
Contributor

@tdykstra tdykstra Aug 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the linked article is Create an ASP.NET Core app with user data protected by authorization -- which is what this article has you do. Might be helpful to explain somewhere the difference between the two.


## Identity Components

The primary reference assembly for the Identity system is `Microsoft.AspNetCore.Identity`. This package contains the core set of interfaces for ASP.NET Core Identity, and is included by `Microsoft.AspNetCore.Identity.EntityFrameworkCore`.
The primary package for Identity is [Microsoft.AspNetCore.Identity](https://www.nuget.org/packages/Microsoft.AspNetCore.Identity/). This package contains the core set of interfaces for ASP.NET Core Identity, and is included by `Microsoft.AspNetCore.Identity.EntityFrameworkCore`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In an email thread I thought we decided that if packages are included in the metapackage you don't have to list them all. Maybe most of this and the following list could be replaced by the mention that everything is in MA.App?


## Identity Components

The primary reference assembly for the Identity system is `Microsoft.AspNetCore.Identity`. This package contains the core set of interfaces for ASP.NET Core Identity, and is included by `Microsoft.AspNetCore.Identity.EntityFrameworkCore`.
The primary package for Identity is [Microsoft.AspNetCore.Identity](https://www.nuget.org/packages/Microsoft.AspNetCore.Identity/). This package contains the core set of interfaces for ASP.NET Core Identity, and is included by `Microsoft.AspNetCore.Identity.EntityFrameworkCore`.

These dependencies are needed to use the Identity system in ASP.NET Core applications:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is potentially misleading insofar as it implies you have to install them. See my comment above questioning whether we need to include this list at all.

@Rick-Anderson Rick-Anderson merged commit 30c029e into master Aug 8, 2018
@Rick-Anderson Rick-Anderson deleted the 8/identity/ra branch August 8, 2018 17:55
@mshwf
Copy link
Contributor

mshwf commented Aug 10, 2018

the issue #7823 is closed now, but the content page is still the same. When will it and the sample project get updated?!

@Rick-Anderson
Copy link
Contributor Author

Usually within 24 hours of merging to master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants