-
-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider adding tests for WASM support #2203
Comments
I think wasm tests here can avoid building the latest
Essentially, the tests here will provide a basic sanity check that wasm apps can be benchmarked. In addition, the |
@radical Do we need to rework how the wasm toolchain works? Or do we already support running it against whatever is in the the workload? |
If you are asking whether running against the workload needs to be implemented, then no, it already works, and |
This was done in #2532. |
WASM support got again broken very recently: dotnet/runtime#78575
We should consider adding automated tests for verifying that WASM just works.
Our Linux CI jobs takes 20+ minutes to execute, so there is plenty of time we can consume (the limit is 1h).
We should mimic what we do for NativeAOT:
BenchmarkDotNet/azure-pipelines.Ubuntu.yml
Lines 17 to 22 in ad8e9b2
BenchmarkDotNet/.github/workflows/build.yaml
Lines 26 to 27 in ad8e9b2
Ideally, we should update the SDK to .NET 7 first: #2080
We don't need to build entire monoVM as described in https://benchmarkdotnet.org/articles/configs/toolchains.html#wasm. We just need to install v8 as described in https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing-wasm.md and follow steps described by @radical here: #1818 (comment)
cc @radical @naricc
The text was updated successfully, but these errors were encountered: