-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Description
WASM support got again broken very recently: dotnet/runtime#78575
We should consider adding automated tests for verifying that WASM just works.
Our Linux CI jobs takes 20+ minutes to execute, so there is plenty of time we can consume (the limit is 1h).
We should mimic what we do for NativeAOT:
- Install dependencies on Linux:
BenchmarkDotNet/azure-pipelines.Ubuntu.yml
Lines 17 to 22 in ad8e9b2
- bash: | wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add - sudo apt-add-repository "deb https://apt.llvm.org/focal/ llvm-toolchain-focal-9 main" sudo apt-get update - bash: | sudo apt-get install cmake clang-9 libicu66 uuid-dev libcurl4-openssl-dev zlib1g-dev libkrb5-dev
BenchmarkDotNet/.github/workflows/build.yaml
Lines 26 to 27 in ad8e9b2
- name: Set up zlib-static run: sudo apt-get install -y libkrb5-dev - Run against hardcoded version to avoid WASM breaking us.
Ideally, we should update the SDK to .NET 7 first: #2080
We don't need to build entire monoVM as described in https://benchmarkdotnet.org/articles/configs/toolchains.html#wasm. We just need to install v8 as described in https://github.com/dotnet/runtime/blob/main/docs/workflow/testing/libraries/testing-wasm.md and follow steps described by @radical here: #1818 (comment)