[wasm] Perf pipeline (dotnet-runtime-perf) completely broken for main

[radical]

Failing build - 20221118.2:

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.PlatformNotSupportedException: System.Diagnostics.FileVersionInfo is not supported on this platform.
   at System.Diagnostics.FileVersionInfo.GetVersionInfo(String )
   at BenchmarkDotNet.Portability.RuntimeInformation.GetNetCoreVersion()
   at BenchmarkDotNet.Portability.RuntimeInformation.GetRuntimeVersion()
   at BenchmarkDotNet.Environments.BenchmarkEnvironmentInfo..ctor()
   at BenchmarkDotNet.Environments.BenchmarkEnvironmentInfo.GetCurrent()
   at BenchmarkDotNet.Autogenerated.Runnable_0.Run(IHost host, String benchmarkName)
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
   --- End of inner exception stack trace ---
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
   at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at BenchmarkDotNet.Autogenerated.UniqueProgramName.AfterAssemblyLoadingAttached(String[] args)

• The previous working build was 20221118.1.
• The only new commit in 20221118.2 was 82054d0 from Fix freebsd cross build with cmake 3.25 #78534 .
• both used dotnet installer 8.0.100-alpha.1.22567.28

cc @am11 @akoeplinger @jkotas

Report

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	0	0

[dotnet-issue-labeler]

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

[ghost]

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Failing build - 20221118.2:

System.Reflection.TargetInvocationException: Exception has been thrown by the target of an invocation.
 ---> System.PlatformNotSupportedException: System.Diagnostics.FileVersionInfo is not supported on this platform.
   at System.Diagnostics.FileVersionInfo.GetVersionInfo(String )
   at BenchmarkDotNet.Portability.RuntimeInformation.GetNetCoreVersion()
   at BenchmarkDotNet.Portability.RuntimeInformation.GetRuntimeVersion()
   at BenchmarkDotNet.Environments.BenchmarkEnvironmentInfo..ctor()
   at BenchmarkDotNet.Environments.BenchmarkEnvironmentInfo.GetCurrent()
   at BenchmarkDotNet.Autogenerated.Runnable_0.Run(IHost host, String benchmarkName)
   at System.Reflection.MethodInvoker.InterpretedInvoke(Object , IntPtr* )
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
   --- End of inner exception stack trace ---
   at System.Reflection.MethodInvoker.Invoke(Object , IntPtr* , BindingFlags )
   at System.Reflection.RuntimeMethodInfo.Invoke(Object , BindingFlags , Binder , Object[] , CultureInfo )
   at System.Reflection.MethodBase.Invoke(Object obj, Object[] parameters)
   at BenchmarkDotNet.Autogenerated.UniqueProgramName.AfterAssemblyLoadingAttached(String[] args)

• The previous working build was 20221118.1.
• The only new commit in 20221118.2 was 82054d0 from Fix freebsd cross build with cmake 3.25 #78534 .
• both used dotnet installer 8.0.100-alpha.1.22567.28

cc @am11 @akoeplinger @jkotas

Author:	radical
Assignees:	-
Labels:	arch-wasm, blocking-clean-ci, perf-pipeline
Milestone:	8.0.0

[am11]

toolchain.cmake is not used in wasm, so i'm not sure how it can break main.

[radical]

I'll try to reproduce this locally.

[radical]

There are multiple parts that can be different between two runs.

• The first suspect is the runtime commit changes. (not applicable, like you said)
• dotnet sdk version difference - they ran with the same one
• Different performance repo branch HEADs - I'm checking this now
• v8 version - shouldn't be relevant here

[jkotas]

Different performance repo branch HEADs - I'm checking this now

Yes, that would be my guess. Likely caused by dotnet/performance#2741

[radical]

Yes, that would be my guess. Likely caused by dotnet/performance#2741

Indeed it is. That bumped BDN from 0.13.2.1950 to 0.13.2.2007, and reverting that changes fixes the issue.
These were the BDN changes in that bump - dotnet/BenchmarkDotNet@eda1a41...9c32a87 .

[radical]

cc @LoopedBard3 @adamsitnik

[adamsitnik]

I won't be able to test it today (11 PM here), but I've merged a change that should solve the problem: dotnet/BenchmarkDotNet#2201

@radical this build should get green within an hour and publish 0.13.2.2009 version

Explanation: dotnet/BenchmarkDotNet#2142 has changed the way we detect Mono runtime to also support MonoVM on .NET 6+:

- public static bool IsMono { get; } = Type.GetType("Mono.Runtime") != null;
+ public static bool IsMono { get; } = Type.GetType("Mono.RuntimeStructs") != null

This affects the code flow in https://github.com/dotnet/BenchmarkDotNet/blob/ad8e9b26ef22aa77abff2469f7668986e1449127/src/BenchmarkDotNet/Portability/RuntimeInformation.cs#L166-L196 (IsMono was before IsWasm) and caused the call to not supported API.

If it does not solve the problem, please just revert the recent BDN version update.

[radical]

Thank you for the super quick fix! I can test this out later today.

[radical]

@LoopedBard3 could you publish the new package to the internal feeds? https://ci.appveyor.com/project/dotnetfoundation/benchmarkdotnet/builds/45428788

[LoopedBard3]

Pushed! @radical

[adamsitnik]

We need to avoid introducing similar breaking changes in the future.

@radical I've created dotnet/BenchmarkDotNet#2203 PTAL and add your thoughts.