Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SDK to .NET 7 #2080

Closed
adamsitnik opened this issue Aug 24, 2022 · 3 comments
Closed

Update SDK to .NET 7 #2080

adamsitnik opened this issue Aug 24, 2022 · 3 comments
Assignees
Milestone

Comments

@adamsitnik
Copy link
Member

We have a test that ensure that latest NativeAOT is supported:

public void LatestNativeAotVersionIsSupported()

Recently it got broken because we can't build a net6.0 app using .NET 7 NativeAOT bits:

 Unable to optimize assemblies for Ahead of time compilation: a valid runti
me package was not found. Either set the PublishAot property to false, or use a supported runtime identifier when publishing. When targeting .NET 7 or higher, make sure to restore packages with the PublishAot property set to true.

So as soon as .NET 7 SDK is shipped, we should just update our CI to use it.

cc @MichalStrehovsky

@adamsitnik adamsitnik added this to the v0.13.x milestone Aug 24, 2022
@adamsitnik adamsitnik mentioned this issue Aug 24, 2022
adamsitnik added a commit that referenced this issue Aug 24, 2022
* set ErrorOnDuplicatePublishOutputFiles to false to stop getting "error NETSDK1152: Found multiple publish output files with the same relative path" about "xunit.runner.json" files

* we can't target net6.0 and use .NET 7 ILCompiler anymore (#2080)
@adamsitnik
Copy link
Member Author

At the time of doing this, we should remove the support for old experimental packages (from the old CoreRT https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet-experimental/nuget/v3/index.json feed)

@timcassell
Copy link
Collaborator

Looks like this is already done since 61b3c56, right @adamsitnik?

@adamsitnik adamsitnik modified the milestones: v0.13.x, v0.13.3 Aug 16, 2023
@adamsitnik
Copy link
Member Author

adamsitnik commented Aug 16, 2023

@timcassell that is correct, thanks for catching it!

fixed with #2209 in 0.13.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants