Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add OnContentReadingCompleted message to multiplexingstream #361

Open
AArnott opened this issue Jun 7, 2021 · 0 comments
Open

Add OnContentReadingCompleted message to multiplexingstream #361

AArnott opened this issue Jun 7, 2021 · 0 comments
Assignees
@AArnott
Labels
enhancement
Milestone
v2.12

Comments

@AArnott
Copy link
Collaborator

AArnott commented Jun 7, 2021 •
edited
Loading

When a channel reader is completed, the remote channel writer doesn't get any feedback on that and may continue writing.

Does it mean there's a deadlock without this, if the writer keeps writing and the reader is no longer reading? Can we fix the deadlock as well, even without the new control code? That would leave the control code as simply an optimization so the writer can quit its work.
sharwell added a commit to sharwell/roslyn that referenced this issue Jun 7, 2021
@sharwell
Rewrite cancellation to avoid closing the reader
833f7e1 
Workaround for dotnet/Nerdbank.Streams#361
Fixes AB#1290793
@sharwell sharwell mentioned this issue Jun 7, 2021
Merged
@AArnott AArnott self-assigned this Jun 7, 2021
@AArnott AArnott added this to the v2.9 milestone Jul 29, 2021
@AArnott AArnott modified the milestones: v2.9, v2.10 Sep 26, 2022
@AArnott AArnott modified the milestones: v2.10, v2.11 Jun 7, 2023
@AArnott AArnott modified the milestones: v2.11, v2.12 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AArnott AArnott

Labels
enhancement
Projects
None yet
Milestone
v2.12
Development

No branches or pull requests
1 participant
@AArnott