Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid cancelling readers before end of stream #53905

Merged
merged 2 commits into from
Jun 10, 2021
Merged

Avoid cancelling readers before end of stream #53905

merged 2 commits into from
Jun 10, 2021

Conversation

sharwell
Copy link
Member

@sharwell sharwell commented Jun 6, 2021 •
edited
Loading

@sharwell sharwell changed the title Isolate reads from writes to avoid cancellation paths Avoid cancelling readers before end of stream Jun 7, 2021
@sharwell sharwell marked this pull request as ready for review June 7, 2021 16:48
@sharwell sharwell requested a review from a team as a code owner June 7, 2021 16:48
CyrusNajmabadi
CyrusNajmabadi approved these changes Jun 7, 2021
View reviewed changes
Copy link
Member

@CyrusNajmabadi CyrusNajmabadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if LGTM to andrew :)

@sharwell sharwell changed the base branch from main to release/dev16.11 June 8, 2021 00:58
@sharwell
Copy link
Member Author

sharwell commented Jun 8, 2021

@jinujoseph for 16.11 approval

@jinujoseph jinujoseph added this to the 16.11 milestone Jun 10, 2021
@sharwell sharwell merged commit af3c1c8 into dotnet:release/dev16.11 Jun 10, 2021
@sharwell sharwell deleted the fix-cancellation branch June 10, 2021 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AArnott AArnott AArnott approved these changes

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

Assignees
No one assigned
Labels
Approved to merge Area-IDE Area-Performance
Projects
None yet
Milestone
16.11
Development

Successfully merging this pull request may close these issues.
5 participants
@sharwell @AArnott @CyrusNajmabadi @jmarolf @jinujoseph