Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Office 2016 support with a few new schema classes #583

Closed
wants to merge 46 commits into from

Conversation

twsouthwick
Copy link
Member

No description provided.

twsouthwick and others added 30 commits December 20, 2017 10:53
There were previously checks at multiple levels to get the schema level.
This change passes the FileFormatVersions object all the way through so
that the decision is done on whether there is a resource or not. In the
future, this will allow new versions with minimal code churn.
* Compact generated schema code (#450)

* Change format version to indicate lowest supported version for schemas (#452)

* Streamline initialization in OpenXmlPartReader (#454)

* Add tests for XmlConvertingReader and simplify code (#453)
Merge master into feature/office2016
@twsouthwick
Copy link
Member Author

@tomjebo

@twsouthwick
Copy link
Member Author

FYI the number changes in O*UnionHelper.g.cs, *.constraints, and *.restraints.xml are due to order differences by inserting properties in. They are calculated during the schema generation and can be considered "magic" numbers. Long term, we can hopefully remove them (I've some progress in removing dependency on them), but for now, it's still needed.

@twsouthwick twsouthwick closed this Apr 1, 2019
@twsouthwick twsouthwick reopened this Apr 1, 2019
@twsouthwick twsouthwick closed this Apr 1, 2019
@twsouthwick twsouthwick reopened this Apr 1, 2019
@twsouthwick twsouthwick closed this Apr 1, 2019
@twsouthwick twsouthwick reopened this Apr 1, 2019
@twsouthwick twsouthwick closed this Apr 1, 2019
@twsouthwick
Copy link
Member Author

Closed in lieu of #586. This was having issues with some of the automated checks

@twsouthwick twsouthwick deleted the feature/office2016 branch April 2, 2019 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants