Add Office2016 support #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update office2016 from master
There were previously checks at multiple levels to get the schema level. This change passes the FileFormatVersions object all the way through so that the decision is done on whether there is a resource or not. In the future, this will allow new versions with minimal code churn.
* Compact generated schema code (dotnet#450) * Change format version to indicate lowest supported version for schemas (dotnet#452) * Streamline initialization in OpenXmlPartReader (dotnet#454) * Add tests for XmlConvertingReader and simplify code (dotnet#453)
Merge master into feature/office2016
Merge from master into Office2016
Documentation correction.
Merge from master
|
FYI the number changes in O*UnionHelper.g.cs, *.constraints, and *.restraints.xml are due to order differences by inserting properties in. They are calculated during the schema generation and can be considered "magic" numbers. Long term, we can hopefully remove them (I've some progress in removing dependency on them), but for now, it's still needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.