SqlAuthenticationParameters.ConnectionTimeout throws MissingMethodException

[smichtch]

Describe the bug

SqlAuthenticationParameters.ConnectionTimeout throws MissingMethodException

System.MissingMethodException: Method not found: 'Int32 Microsoft.Data.SqlClient.SqlAuthenticationParameters.get_ConnectionTimeout()'.
   at Microsoft.Data.ProviderBase.DbConnectionPool.CheckPoolBlockingPeriod(Exception e)
   at Microsoft.Data.ProviderBase.DbConnectionPool.CreateObject(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.UserCreateRequest(DbConnection owningObject, DbConnectionOptions userOptions, DbConnectionInternal oldConnection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, UInt32 waitForMultipleObjectsTimeout, Boolean allowCreate, Boolean onlyOneCheckConnection, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionPool.TryGetConnection(DbConnection owningObject, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionFactory.TryGetConnection(DbConnection owningConnection, TaskCompletionSource`1 retry, DbConnectionOptions userOptions, DbConnectionInternal oldConnection, DbConnectionInternal& connection)
   at Microsoft.Data.ProviderBase.DbConnectionInternal.TryOpenConnectionInternal(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.ProviderBase.DbConnectionClosed.TryOpenConnection(DbConnection outerConnection, DbConnectionFactory connectionFactory, TaskCompletionSource`1 retry, DbConnectionOptions userOptions)
   at Microsoft.Data.SqlClient.SqlConnection.TryOpen(TaskCompletionSource`1 retry, SqlConnectionOverrides overrides)
   at Microsoft.Data.SqlClient.SqlConnection.Open(SqlConnectionOverrides overrides)
   at Microsoft.Data.SqlClient.SqlConnection.Open()
   at DatabaseTestController.TestSqlConnection(Action`1 customize)

To reproduce

Reproduces by accessing ConnectionTimeout from a custom SqlAuthenticationProvider:

class MyCustomSqlAuthenticationProvider : SqlAuthenticationProvider
{
    public override async Task<SqlAuthenticationToken> AcquireTokenAsync(SqlAuthenticationParameters parameters)
    {
        // System.MissingMethodException thrown here
        var connectionTimeout = parameters.ConnectionTimeout;
        ...
    }
    ...
}

Expected behavior

SqlAuthenticationParameters.ConnectionTimeout returns an integer value.

Further technical details

Microsoft.Data.SqlClient version: 3.0.1
.NET target: netcoreapp3.1 and net472
SQL Server version: N/A
Operating system: Windows 10 Enterprise Build 19043

Additional context
It looks like SqlAuthenticationParameters.ConnectionTimeout is implemented a a field

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/SqlAuthenticationParameters.cs

Line 41 in 6c46392

public int ConnectionTimeout = ADP.DefaultConnectionTimeout;

but in the ref assemblies it's a property:

SqlClient/src/Microsoft.Data.SqlClient/netfx/ref/Microsoft.Data.SqlClient.cs

Line 152 in 6c46392

public int ConnectionTimeout { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }

SqlClient/src/Microsoft.Data.SqlClient/netcore/ref/Microsoft.Data.SqlClient.cs

Line 196 in 6c46392

public int ConnectionTimeout { [System.Runtime.CompilerServices.CompilerGeneratedAttribute]get { throw null; } }

Seems like it might just be a typo (i.e. impl missing a { get; }) but since SqlAuthenticationParameters is marked partial maybe I'm not seeing some generated code.

[cheenamalhotra]

Hi @smichtch

I'm leaning to agree it should have been a property, but strangely it works fine for our provider implementation.

SqlClient/src/Microsoft.Data.SqlClient/src/Microsoft/Data/SqlClient/ActiveDirectoryAuthenticationProvider.cs

Line 111 in 4316474

cts.CancelAfter(parameters.ConnectionTimeout * 1000); // Convert to milliseconds

but since SqlAuthenticationParameters is marked partial maybe I'm not seeing some generated code.

I think that is a left over keyword, the class is complete in ref project.

[smichtch]

@cheenamalhotra ActiveDirectoryAuthenticationProvider in Microsoft.Data.SqlClient is not looking at the ref assemblies, it's getting the field from the implementation class directly:

[cheenamalhotra]

Yes, I just tried in standalone and found this issue as well.

I've opened PR #1336 to address this, below package is built with this change, please try and let me know.

Add to local feed: Microsoft.Data.SqlClient.4.0.0-dev.nupkg.zip
<PackageReference Include="Microsoft.Data.SqlClient" Version="4.0.0-dev" />

Thanks for catching this bug 👍🏻