Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix get_ConnectionTimeout property API in SqlAuthenticationParameters #1336

Merged
merged 6 commits into from
Oct 15, 2021
Merged

Fix get_ConnectionTimeout property API in SqlAuthenticationParameters #1336

merged 6 commits into from
Oct 15, 2021

Conversation

cheenamalhotra
Copy link
Member

@cheenamalhotra cheenamalhotra commented Oct 12, 2021 •
edited
Loading

Fixes #1335

Low impact breaking change:

  • The "Connection Timeout" property was recently introduced in SqlAuthenticationParameters in v3.0.0-preview2.

@cheenamalhotra cheenamalhotra mentioned this pull request Oct 12, 2021
Closed
@cheenamalhotra cheenamalhotra added the 🔨 Breaking Change Use this label for breaking API changes in the driver. label Oct 12, 2021
@cheenamalhotra cheenamalhotra added this to the 4.0.0-preview3 milestone Oct 12, 2021
@Wraith2
Copy link
Contributor

Wraith2 commented Oct 12, 2021

Looks good to me.

@JRahnama JRahnama merged commit 47ff527 into dotnet:main Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnypham johnnypham johnnypham approved these changes

@JRahnama JRahnama JRahnama approved these changes

@DavoudEshtehari DavoudEshtehari DavoudEshtehari approved these changes

@Kaur-Parminder Kaur-Parminder Awaiting requested review from Kaur-Parminder

Assignees
No one assigned
Labels
🔨 Breaking Change Use this label for breaking API changes in the driver.
Projects
None yet
Milestone
4.0.0-preview3
Development

Successfully merging this pull request may close these issues.

SqlAuthenticationParameters.ConnectionTimeout throws MissingMethodException
5 participants
@cheenamalhotra @Wraith2 @johnnypham @JRahnama @DavoudEshtehari