Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question: Is Microsoft.Data.SqlClient not souce code open source and is there some docs? #3

Closed
WeihanLi opened this issue May 7, 2019 · 2 comments
Closed

Question: Is Microsoft.Data.SqlClient not souce code open source and is there some docs? #3

WeihanLi opened this issue May 7, 2019 · 2 comments

Comments

@WeihanLi
Copy link

WeihanLi commented May 7, 2019

Is Microsoft.Data.SqlClient not souce code open source and is there some docs?
@WeihanLi
Copy link
Author

WeihanLi commented May 7, 2019

find the answer in the wiki here, sorry for this issue

@WeihanLi WeihanLi closed this as completed May 7, 2019
@divega
Copy link

divega commented May 7, 2019

sorry for this issue

No need to apologize. The fact that you care that is open source is good feedback!

karinazhou added a commit that referenced this issue Mar 13, 2021
@DavoudEshtehari @karinazhou @winseros
Supporting Event counter in .Net core (#719)
884b113 
* Add event counters

* Add support netstandard 2.1 & fix the conflict in event source

* Support new event source types & add the test unit

* Remove supporting obsolete types

* fix unit test

* Add snippet sample code

* Address comments

* Fix minor typo (#3)

* Reformatting counter methods

* Fix minor typo

* Removed IsEnabled condition and reformatted counter methods

* Unit tests for Microsoft.Data.SqlClient.SqlClientEventSource (#2)

* Implemented tests for Microsoft.Data.SqlClient.SqlClientEventSource

* Updated the EventCounter test to reflect the recent changes in the code

* Working on EventCounter tests access event counters through reflection

* Updated the EventCounterTest to use reflection

* Fixing dangling SqlConnection's left in tests

* EventCountersTest now checks hard/soft connects/disconnects counters

* Reverted the DataTestUtility changes

* Reverted using statements to the old-style in tests

* Reverted the ConnectionPoolTest.ReclaimEmancipatedOnOpenTest()

* Reverted using statements to the old-style in tests

* Reverted using statements to the old-style in tests

* Rewrite the EventCounterTest assertions not to conflict with other tests

* Code review cleanup

* Add more tests (#5)

Added EventCounter_ReclaimedConnectionsCounter_Functional & EventCounter_ConnectionPoolGroupsCounter_Functional tests.

* Address comments

Co-authored-by: Davoud Eshtehari <David.esh@gmail.com>
Co-authored-by: Davoud Eshtehari <v-daesht@microsoft.com>
Co-authored-by: Karina Zhou <v-jizho2@microsoft.com>
Co-authored-by: Nikita Kobzev <win.accuracy@gmail.com>
@danmoseley danmoseley mentioned this issue May 10, 2021
Closed
@DavoudEshtehari DavoudEshtehari mentioned this issue Apr 1, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@divega @WeihanLi