AKV Trusted URL cleanup #3487
Merged
AKV Trusted URL cleanup #3487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the TrustedUrlsTest by removing an obsolete constant and debug output, and streamlining the assertion logic.
- Removed the
InvalidVaultKeyPathErrorMessageconstant - Removed
Console.WriteLinestatements used for debugging - Inlined the expected regex into the
Assert.Matchescall
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3487 +/- ##
==========================================
- Coverage 69.78% 69.77% -0.01%
==========================================
Files 277 277
Lines 62249 62245 -4
==========================================
- Hits 43441 43433 -8
- Misses 18808 18812 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
paulmedynski
changed the title
David-Engel
approved these changes
Jul 17, 2025
apoorvdeshmukh
approved these changes
Jul 17, 2025
paulmedynski
added a commit
that referenced
this pull request
Jul 23, 2025
This reverts commit 4bbf8c6.
paulmedynski
added a commit
that referenced
this pull request
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.