Revert recent AKV URL changes #3506
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR reverts recent Azure Key Vault (AKV) URL changes by rolling back PRs #3482 and #3487. The revert simplifies trusted endpoint validation by removing recently added sovereign cloud endpoints and associated test infrastructure.
- Removes sovereign cloud endpoints for France and Germany from the trusted AKV domain list
- Deletes the TrustedUrlsTest.cs test file that was testing URL validation
- Reverts project file organization changes and inline error message validation
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Microsoft.Data.SqlClient.ManualTesting.Tests.csproj | Reorganizes test file inclusions and removes TrustedUrlsTest.cs reference |
| TrustedUrlsTest.cs | Complete removal of test file for AKV URL validation |
| ExceptionTestAKVStore.cs | Replaces shared error message helper with inline error message validation |
| Utils.cs | Changes return type from ArgumentException to Exception for InvalidAKVUrlTrustedEndpoints method |
| Constants.cs | Removes sovereign cloud endpoints and reverts to collection expression syntax |
apoorvdeshmukh
approved these changes
Jul 23, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3506 +/- ##
==========================================
+ Coverage 64.78% 68.89% +4.11%
==========================================
Files 276 276
Lines 62192 62184 -8
==========================================
+ Hits 40289 42843 +2554
+ Misses 21903 19341 -2562
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cheenamalhotra
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Reverts #3482 and #3487.