Mark all assemblies as Trimmable via Directory.Build.props. #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
reviewed
Mar 31, 2022
akoeplinger
approved these changes
Mar 31, 2022
jonathanpeppers
approved these changes
Mar 31, 2022
There was a problem hiding this comment.
This seems to get the assembly right:
Do we also need to bump some version numbers & dependencies to fully fix #519?
|
Yes, we will need to bump and release all of AndroidX in a separate PR. |
eerhardt
reviewed
Mar 31, 2022
| @@ -15,6 +15,9 @@ | |||
|
|
|||
| <!-- .NET 6+ packages support back to API-21 --> | |||
| <SupportedOSPlatformVersion>21</SupportedOSPlatformVersion> | |||
|
|
|||
| <!-- Mark .NET6+ packages as supporting trimming --> | |||
| <IsTrimmable>true</IsTrimmable> | |||
There was a problem hiding this comment.
Should we also remove this line?
This was referenced Apr 4, 2022
jonathanpeppers
added a commit
to jonathanpeppers/xamarin-android
that referenced
this pull request
Jan 10, 2024
To keep app sizes down in the .NET 6 timeframe, we special-cased existing AndroidX and GPS packages so they were always trimmed. Modern packages mark themselves trimmable with `$(IsTrimmable)` or the assembly-level attribute. For nearly 2 years, we've applied the appropriate trimming setting in these packages: * dotnet/android-libraries#520 * xamarin/GooglePlayServicesComponents#597 We should be able to remove this now in .NET 9.
jonathanpeppers
added a commit
to dotnet/android
that referenced
this pull request
Jan 11, 2024
To keep app sizes down in the .NET 6 timeframe, we special-cased existing AndroidX and GPS packages so they were always trimmed. Modern packages mark themselves trimmable with `$(IsTrimmable)` or the assembly-level attribute. For nearly 2 years, we've applied the appropriate trimming setting in these packages: * dotnet/android-libraries#520 * xamarin/GooglePlayServicesComponents#597 We should be able to remove this now in .NET 9. With this change in place, an existing app size regression test failed that was using an old version of Xamarin.Forms (and AndroidX): Saving apk description to 'BuildReleaseArm64XFormsDotNet.apkdesc' Size difference in bytes ([*1] apk1 only, [*2] apk2 only): 253,683 assemblies/Xamarin.AndroidX.Core.dll 179,063 assemblies/Xamarin.Google.Android.Material.dll 157,233 assemblies/Xamarin.AndroidX.AppCompat.dll 104,239 assemblies/Xamarin.AndroidX.Media.dll *2 52,862 assemblies/Xamarin.AndroidX.Annotation.dll *2 48,743 assemblies/Xamarin.AndroidX.RecyclerView.dll 39,419 assemblies/Xamarin.AndroidX.Transition.dll *2 38,993 assemblies/Xamarin.AndroidX.Browser.dll *2 To avoid this increase: update the app size test from Xamarin.Forms 4.7.0.1142 to 5.0.0.2515. This allowed us to no longer need the `%(TrimMode)=link` changes, however updating Xamarin.Forms increased app size in other ways. * New AndroidX libraries contain considerable more `AndroidResource` and Java code. * New AndroidX `.dll` files appeared for new packages. * Luckily, it appears that no AndroidX `.dll` files grew in size, which is what would be the result of the `%(TrimMode)=link` change if it were still needed. Overall app size change in this test: --"PackageSize": 7941134 ++"PackageSize": 9593384
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #519
In Xamarin.Android Classic we link all assemblies by default unless the user opts out. In .NET6+, assemblies must opt-in to being linked by setting
$(IsTrimmable).We already had this for packages using the default AndroidX template, but AndroidX dependencies (like Kotlin) bound in this repository use other templates that did not include trimming.
Enable trimming via
Directory.Build.targetsto ensure it affects all assemblies.From CI build for
Xamarin.Kotlin.Stdlib.dll: