[Xamarin.Android.Build.Tasks] remove %(TrimMode)=link metadata
#8624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To keep app sizes down in the .NET 6 timeframe, we special-cased existing AndroidX and GPS packages so they were always trimmed. Modern packages mark themselves trimmable with `$(IsTrimmable)` or the assembly-level attribute. For nearly 2 years, we've applied the appropriate trimming setting in these packages: * dotnet/android-libraries#520 * xamarin/GooglePlayServicesComponents#597 We should be able to remove this now in .NET 9.
|
As anticipated: Going to update various tests to latest Xamarin.Forms 5.0.0.2622. |
jonathanpeppers
commented
Jan 11, 2024
Comment on lines
-209
to
+218
| "Size": 3502580 | ||
| "Size": 5908848 |
There was a problem hiding this comment.
Xamarin.Forms 5 has a lot newer AndroidX libraries... Which is apparently a lot more Java code.
Comment on lines
+550
to
+552
| "res/animator/linear_indeterminate_line2_tail_interpolator.xml": { | ||
| "Size": 400 | ||
| }, |
There was a problem hiding this comment.
Lots of new resources.
Comment on lines
187
to
+197
| "assemblies/Xamarin.AndroidX.RecyclerView.dll": { | ||
| "Size": 89997 | ||
| "Size": 93990 | ||
| }, | ||
| "assemblies/Xamarin.AndroidX.SavedState.dll": { | ||
| "Size": 4909 | ||
| "Size": 4969 | ||
| }, | ||
| "assemblies/Xamarin.AndroidX.SwipeRefreshLayout.dll": { | ||
| "Size": 10575 | ||
| "Size": 13974 | ||
| }, | ||
| "assemblies/Xamarin.AndroidX.ViewPager.dll": { | ||
| "Size": 18594 | ||
| "Size": 19073 |
There was a problem hiding this comment.
Overall not seeing any Xamarin.AndroidX.*.dll files grow, which is good. 👍
Comment on lines
2281
to
+2285
| "resources.arsc": { | ||
| "Size": 325240 | ||
| "Size": 777972 | ||
| } | ||
| }, | ||
| "PackageSize": 7941134 | ||
| "PackageSize": 9593384 |
There was a problem hiding this comment.
The app grew quite a bit going from Xamarin.Forms 4.7 -> Xamarin.Forms 5.
dellis1972
approved these changes
Jan 11, 2024
grendello
added a commit
that referenced
this pull request
Jan 11, 2024
* main: [Xamarin.Android.Build.Tasks] remove `%(TrimMode)=link` metadata (#8624)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To keep app sizes down in the .NET 6 timeframe, we special-cased existing AndroidX and GPS packages so they were always trimmed.
Modern packages mark themselves trimmable with
$(IsTrimmable)or the assembly-level attribute.For nearly 2 years, we've applied the appropriate trimming setting in these packages:
We should be able to remove this now in .NET 9.