Skip to content

Collected API improvements #4

@jonpryor

Description

@jonpryor

Collected API improvements while reviewing dotnet/android#89

Namespace should be Xamarin.Zip or Xamarin.Tools.Zip, not Xamarin.ZipSharp. A Sharp suffix adds nothing.

ZipArchive.NumberOfEntries should be named ZipArchive.EntryCount. Alternatively, maybe follow System.IO.Collections and have an Entries property of ICollection<ZipEntry> with a Count property.

ZipEntry.Name should be ZipEntry.FullName, a'la System.IO.Collections, if (I assume!) the value is the "full" name of an entry within the .zip file, e.g. foo/bar/baz.txt instead of just baz.txt.

ZipArchive.AddFile(string, CompressionMethod) should name the CompressionMethod parameter compressionMethod, not just method.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions