Added Support for Building libzip for Mac and Windows #89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xamarin.Android.sln
Outdated
| {C03E6CF1-7460-4CDC-A4AB-292BBC0F61F2}.XAIntegrationRelease|Any CPU.ActiveCfg = Debug|Any CPU | ||
| {C03E6CF1-7460-4CDC-A4AB-292BBC0F61F2}.XAIntegrationRelease|Any CPU.Build.0 = Debug|Any CPU | ||
| {C03E6CF1-7460-4CDC-A4AB-292BBC0F61F2}.XAIntegrationDebug|AnyCPU.ActiveCfg = Debug|Any CPU | ||
| {C03E6CF1-7460-4CDC-A4AB-292BBC0F61F2}.XAIntegrationDebug|AnyCPU.Build.0 = Debug|Any CPU |
Contributor
There was a problem hiding this comment.
These are some odd changes... IDEs are fun!
I wonder how that impacts msbuild building...
dellis1972
force-pushed
the
libzip
branch
5 times, most recently
from
82e0794 to
14a564d
Compare
build-tools/libzip/libzip.targets
Outdated
| <Import Project="libzip.props" /> | ||
| <Import Project="libzip.projitems" /> | ||
| <Target Name="_Make" | ||
| Inputs="" |
Contributor
There was a problem hiding this comment.
No inputs means make will always be executed.
As suggested earlier (which I can't find?!), you should follow mono-runtimes.targets:
- Have a target, e.g.
_SetConfigureAcTimeToLastCommitTimestamp, which usestouch -mto set the timestamp on e.g.configure.acto the timestamp of the last commit in that repo. - Add
_SetConfigureAcTimeToLastCommitTimestampto theDependsOnTargetsof the_Maketarget. - Depend on e.g.
configure.acas anInputsto the_Maketarget.
The timestamp + touch computation are (reasonably) quick, whereas invoking make might not be. (For example, top-level make within monodroid is slow, even when there's nothing to do!)
dellis1972
changed the title
Contributor
Author
|
@jonpryor updated |
build-tools/libzip/libzip.targets
Outdated
| WorkingDirectory="$(LibZipSourceFullPath)" | ||
| /> | ||
| </Target> | ||
| <Target Name="_Configure" DependsOnTargets="_SetCMakeListsTxtTimeToLastCommitTimestamp"> |
Contributor
There was a problem hiding this comment.
This should still have an Inputs="$(LibZipSourceFullPath)\CMakeLists.txt" and an appropriate Outputs.
dellis1972
force-pushed
the
libzip
branch
2 times, most recently
from
cb6f2ef to
6441103
Compare
radical
pushed a commit
that referenced
this pull request
May 8, 2018
…ories (#89) The `TypeNameMapGenerator(IEnumerable<string>, Action<string,object[]>)` constructor attempted to use `DirectoryAssemblyResolver` to load each assembly provided by the `IEnumerable<string>` parameter, in-order, *without* updating `DirectoryAssemblyResolver.SearchDirectories`. The result is that things would only work if the assemblies were sorted in "dependency order", e.g. `mscorlib.dll` first, and any other assembly dependency before it's used. Should the order be otherwise, e.g. `{System.dll, mscorlib.dll}`, then things would horrifically break: System.IO.FileNotFoundException: Could not load assembly 'mscorlib, Version=2.0.5.0, Culture=neutral, PublicKeyToken=7cec85d7bea7798e'. Perhaps it doesn't exist in the Mono for Android profile? File name: 'mscorlib.dll' at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference reference, Mono.Cecil.ReaderParameters parameters) [0x0015d] in <216e7ad0b70c419890a52554f287cdcd>:0 at Java.Interop.Tools.Cecil.DirectoryAssemblyResolver.Resolve (Mono.Cecil.AssemblyNameReference reference) [0x00001] in <216e7ad0b70c419890a52554f287cdcd>:0 at Mono.Cecil.MetadataResolver.Resolve (Mono.Cecil.TypeReference type) [0x0004e] in <4f9b8c8361824d0ca9025449919e12be>:0 at Mono.Cecil.ModuleDefinition.Resolve (Mono.Cecil.TypeReference type) [0x00007] in <4f9b8c8361824d0ca9025449919e12be>:0 at Mono.Cecil.TypeReference.Resolve () [0x00014] in <4f9b8c8361824d0ca9025449919e12be>:0 Improver the `TypeNameMapGenerator` constructor so that `DirectoryAssemblyResolver.SearchDirectories` is set to contain all directories for all assemblies provied, *before* attempting to load any assemblies. This allows assemblies to be provided in an arbitrary order, while still allowing assemblies to be found.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Oct 8, 2020
Changes: dotnet/android-tools@a6a23bb...1878e43 * dotnet/android-tools@1878e43: [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (dotnet#96) * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (dotnet#97) * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (dotnet#91) * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (dotnet#89)
jonpryor
added a commit
that referenced
this pull request
Oct 12, 2020
Changes: dotnet/android-tools@a6a23bb...1878e43 * dotnet/android-tools@1878e43: [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (#96) * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (#97) * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (#91) * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (#89)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pending submodule setup. This PR is for review only atm.
It adds the ability to build lib zip for Mac / Windows