Fix an issue where all the assemblies are added with the name assembies. #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the commit f3d62b6 which switches over to using libzip there was an oversight. The new API needs the filename in the archive not just the directory (like IonicZip did). As a result the code was making ALL the assemblies have the same name. This commit fixes that issue by appending the filename to the "assemblies" path. It also fixes an issue with the typemap files not being added to the root of the apk.
dellis1972
force-pushed
the
fixassemblies
branch
from
8c0af8d to
c812403
Compare
radical
pushed a commit
that referenced
this pull request
May 8, 2018
* Added ApiXml file doc parser This will parse parameter names from an xml file in the api.xml format. * Added test for ApiXml doc parser * Make name more obviously for internal use
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Oct 8, 2020
Changes: dotnet/android-tools@a6a23bb...1878e43 * dotnet/android-tools@1878e43: [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (dotnet#96) * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (dotnet#97) * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (dotnet#91) * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (dotnet#89)
jonpryor
added a commit
that referenced
this pull request
Oct 12, 2020
Changes: dotnet/android-tools@a6a23bb...1878e43 * dotnet/android-tools@1878e43: [Xamarin.Android.Tools.AndroidSdk] Error & Warning Localization (#96) * dotnet/android-tools@f2af06f: [Xamarin.Android.Tools.AndroidSdk] Fix a few nullability warnings (#97) * dotnet/android-tools@5718cd2: Fix sort ordering for ndk-bundle, add macOS support (#91) * dotnet/android-tools@8e63795: [Xamarin.Android.Tools.AndroidSdk] Add API-29, API-30 to KnownVersions (#89)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the commit f3d62b6 which switches over to using libzip there was
an oversight. The new API needs the filename in the archive
not just the directory (like IonicZip did). As a result the code
was making ALL the assemblies have the same name.
This commit fixes that issue by appending the filename to the
"assemblies" path.