Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests] Audit tests annotated with DotNetIgnore or other ignored categories #7777

Closed
pjcollins opened this issue Feb 7, 2023 · 1 comment · Fixed by #8246
Closed

[Tests] Audit tests annotated with DotNetIgnore or other ignored categories #7777

pjcollins opened this issue Feb 7, 2023 · 1 comment · Fixed by #8246
Assignees
@dellis1972 @pjcollins
Labels
Area: Unit Tests Issues with repo unit tests.
Milestone
.NET 8

Comments

@pjcollins
Copy link
Member

pjcollins commented Feb 7, 2023 •
edited
Loading

Now that we are no longer running some classic tests in CI, we should review the MSBuild tests that are ignored in the One .NET test runs to make sure we aren't missing any coverage.

On a quick search, the DeleteBinObjTests fixture and potentially other tests in BuildTest.cs may be worth updating to run against .NET.
@pjcollins pjcollins added this to the .NET 8 milestone Feb 7, 2023
@pjcollins pjcollins self-assigned this Feb 7, 2023
@ghost ghost added the needs-triage Issues that need to be assigned. label Feb 7, 2023
@pjcollins pjcollins added Area: Unit Tests Issues with repo unit tests. and removed needs-triage Issues that need to be assigned. labels Feb 7, 2023
@pjcollins pjcollins changed the title [Build Tests] Audit tests annotated with DotNetIgnore or other ignored categories [Tests] Audit tests annotated with DotNetIgnore or other ignored categories Feb 7, 2023
@pjcollins pjcollins mentioned this issue May 15, 2023
Merged
@pjcollins
Copy link
Member Author

#8163 addresses most of this, we will only need to look at the HybridAOT, MonoSymbolicate, and StaticProject categories in a future PR.

@pjcollins pjcollins mentioned this issue Jul 7, 2023
Merged
pjcollins added a commit to pjcollins/android that referenced this issue Aug 7, 2023
@pjcollins
[tests] Remove the last set of ignored MSBuild tests
d391207 
Fixes: dotnet#7777

The last set of ignored test categories have been removed or migrated to
existing tests:

  * Test configurations related to AotMode=Hybrid and AotMode=Full have been removed.

  * BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output.

  * EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output.

  * PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output.

  * EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents.

  * EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts.

  * EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs.

  * EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.
@pjcollins pjcollins mentioned this issue Aug 7, 2023
Merged
pjcollins added a commit that referenced this issue Aug 9, 2023
@pjcollins
[tests] Remove the last set of ignored MSBuild tests (#8246)
a427688 
Fixes: #7777

The last set of ignored test categories have been removed or migrated to
existing tests:

  * Test configurations related to AotMode=Hybrid and AotMode=Full have been removed.

  * BuildTest.CheckSequencePointGeneration has been removed due to it relying on mono symbol output.

  * EnvironmentContentTests.CheckBuildIdIsUnique has been removed due to it relying on mono symbol output.

  * PackagingTest.CheckManagedSymbolsArchive has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateAndroidStackTrace has been removed due to it relying on mono symbol output.

  * InstallAndRunTests.MonoSymbolicateNetStandardStackTrace has been removed due to it relying on mono symbol output.

  * EmbeddedDSOTests.BinariesExist removed as it is implicitly covered by tests that validate .apk contents.

  * EmbeddedDSOTests.EnvironmentFileContents removed as it is covered by BuildTest.CheckAssemblyCounts.

  * EmbeddedDSOTests.DSOPageAlignment assert moved to PackagingTest.EmbeddedDSOs.

  * EmbeddedDSOTests.DSOCompressionMode and EmbeddedDSOTests.AndroidManifestHasFlag removed as they are covered by PackagingTest.EmbeddedDSOs.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dellis1972 dellis1972

@pjcollins pjcollins

Labels
Area: Unit Tests Issues with repo unit tests.
Projects
None yet
Milestone
.NET 8
Development

Successfully merging a pull request may close this issue.

[tests] Remove the last set of ignored MSBuild tests pjcollins/android
2 participants
@dellis1972 @pjcollins