Clean up DotNetIgnore Unit Tests #8163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
dotnetignorecleanup
branch
from
2a393d6
to
fa7ff51
Compare
|
Test failures are our good friend |
jonathanpeppers
approved these changes
Jul 6, 2023
pjcollins
reviewed
Jul 7, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidUpdateResourcesTest.cs
Outdated
Show resolved
Hide resolved
pjcollins
reviewed
Jul 7, 2023
src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/BuildTest.cs
Outdated
Show resolved
Hide resolved
dellis1972
force-pushed
the
dotnetignorecleanup
branch
from
8003ad4
to
00609d4
Compare
dellis1972
force-pushed
the
dotnetignorecleanup
branch
from
11617da
to
8ab107a
Compare
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 20, 2023
* main: Bump to dotnet/installer@ca467d68c8 8.0.100-preview.7.23364.32 (dotnet#8176) Clean up DotNetIgnore Unit Tests (dotnet#8163)
grendello
added a commit
to grendello/xamarin-android
that referenced
this pull request
Jul 24, 2023
* main: $(AndroidPackVersionSuffix)=rc.1; net8 is 34.0.0-rc.1 (dotnet#8204) Bump to dotnet/installer@ca467d68c8 8.0.100-preview.7.23364.32 (dotnet#8176) Clean up DotNetIgnore Unit Tests (dotnet#8163) [Xamarin.Android.Build.Tasks] fix duplicate `.aar` files (dotnet#8196) [Documentation] Appease PoliCheck Rule: 79604 (dotnet#8197)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have recently begun to remove suport for Xamarin.Android Classic.
Many of the Unit Tests labeled with the "DotNetIgnore" Category were flagged
as such because they did not work under .Net Android. This commit goes through
and removes tests which are not relevant in the .Net Android context. It also
modifies some of these tests which are relevant to work under .Net Android.