Bump to xamarin-android-api-compatibility/master/2c689ef2 #1328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#1089 We found that xamarin-android-api-compatibility wasn't *actually* performing the inter-API-level checks, meaning an important API compatibility check wasn't being performed. Bump to xamarin-android-api-compatibility/2c689ef2 so that inter-API-level checks are properly performed. Additionally, set `$(HTML_OUTPUT_DIR)` so that `mono-api-html` output files are written into `bin/Build$(CONFIGURATION)/compatibility`. This will (hopefully) allow us to use the Jenkins **Publish HTML reports** Post-build Action to nicely display API compatibility breakage, without requiring that we read the actual build log output.
jonpryor
added
the
full-mono-integration-build
Contributor
Author
|
build |
Contributor
|
Those test failures are irrelevant. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1089
We found that xamarin-android-api-compatibility wasn't actually
performing the inter-API-level checks, meaning an important API
compatibility check wasn't being performed.
Bump to xamarin-android-api-compatibility/2c689ef2 so that
inter-API-level checks are properly performed.
Additionally, set
$(HTML_OUTPUT_DIR)so thatmono-api-htmloutputfiles are written into
bin/Build$(CONFIGURATION)/compatibility.This will (hopefully) allow us to use the Jenkins
Publish HTML reports Post-build Action to nicely display API
compatibility breakage, without requiring that we read the actual
build log output.