Skip to content

Conversation

@jonathanpeppers
Copy link
Member

@jonathanpeppers jonathanpeppers commented Mar 14, 2018

To get our desired behavior on VSTS, we have to:

  • Make sure our call to NUnit returns a failing exit code
  • Set the "Continue on Error" option in VSTS
  • Add a step at the end of our build definition in VSTS to fail the
    build if any issues ocurred

To make this work, we have to change our <Exec /> task usage to
ContinueOnError="ErrorAndContinue".

Example builds with a failing test can be found here:

@jonathanpeppers jonathanpeppers added the do-not-merge PR should not be merged. label Mar 14, 2018
@jonathanpeppers
Copy link
Member Author

Waiting on dotnet/java-interop#274 to finish this up.

@jonathanpeppers jonathanpeppers changed the title [tests] fix for VSTS Windows builds [tests] support for running tests on VSTS Mar 20, 2018
jonpryor pushed a commit that referenced this pull request Mar 21, 2018
To get our desired behavior on VSTS, we have to:
- Make sure our call to NUnit returns a failing exit code
- Set the "Continue on Error" option in VSTS
- Add a step at the end of our build definition in VSTS to fail the
build if any issues ocurred

To make this work, we have to change our `<Exec />` task usage to
`ContinueOnError="ErrorAndContinue"`.

Example builds with a failing test can be found here:
- https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1502302&tab=ms.vss-test-web.test-result-details
- https://jenkins.mono-project.com/job/xamarin-android-pr-builder/2739/
@jonathanpeppers jonathanpeppers removed the do-not-merge PR should not be merged. label Mar 21, 2018
@jonathanpeppers
Copy link
Member Author

jonathanpeppers commented Mar 21, 2018

Changes needed on VSTS have been published here.

Apparently, my draft build link on VSTS no longer works after publishing 😕

@jonpryor jonpryor merged commit 3d7487c into dotnet:master Mar 22, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
@jonathanpeppers jonathanpeppers deleted the windows-nunit branch February 21, 2024 18:39
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants