[build] fix for unit tests to run on VSTS #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To get our desired behavior on VSTS, we have to: - Make sure our call to NUnit returns a failing exit code - Set the "Continue on Error" option in VSTS - Add a step at the end of our build definition in VSTS to fail the build if any issues ocurred To make this work, we have to change our `<Exec />` task usage to `ContinueOnError="ErrorAndContinue"`. I tested the VSTS behavior upstream in xamarin-android, see a build here: https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1478269 Other changes: - Added `Resource.designer.cs` to .gitignore to match xamarin-android
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To get our desired behavior on VSTS, we have to:
build if any issues ocurred
To make this work, we have to change our
<Exec />task usage toContinueOnError="ErrorAndContinue".I tested the VSTS behavior upstream in xamarin-android, see a build here:
https://devdiv.visualstudio.com/DevDiv/_build/index?buildId=1478269
Other changes:
Resource.designer.csto .gitignore to match xamarin-android