[Xamarin.Android.Build.Tasks] Use a Response file for javac

[dellis1972]

Context https://devdiv.visualstudio.com/DevDiv/_workitems/edit/599161

We currently only use a response file for .java files.
Looking at the docs there is no reason why we can't use
them for all of the arguments. This should help with
problems where windows has a max command line length.

[jonpryor]

As pointed out on our call, while using a javac response file may overall be a Good Idea™, it will not fix the System.IO.PathTooLongException, as that results from attempting to add a file in a "too long" path into classes.zip after running javac.

javac ran successfully. As such, it's not part of the problem.

[dellis1972]

build

[dellis1972]

build

[dellis1972]

@jonp the failing test is

RemotingServicesTest.Xamarin.Android.Bcl_Tests, MonoTests.System.Runtime.Remoting.RemotingServicesTest.Bug46473 / Debug

So I think this is good to go!!

[dellis1972]

ok this is good. Test is un related .ConditionalWeakTableTest.OldGenStress / Debug

[dellis1972]

build

[dellis1972]

build

[jonpryor]

macOS PR Build log shows the problem: too many quotes in <Javac/>:

    Javac Task (TaskId:187)
...
    -d ""obj/Test Config/android/bin/classes"" (TaskId:187)
    -bootclasspath "/Users/builder/android-toolchain/sdk/platforms/android-28/android.jar" (TaskId:187)
    -classpath "/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-android/bin/Debug/lib/xamarin.android/xbuild-frameworks/MonoAndroid/v9.0/mono.android.jar:/Users/builder/jenkins/workspace/xamarin-android-pr-builder/xamarin-andro
id/bin/Debug/lib/xamarin.android/xbuild/Xamarin/Android/android-support-multidex.jar" (TaskId:187)
    -encoding UTF8 (TaskId:187)
    /Library/Java/JavaVirtualMachines/jdk1.8.0_91.jdk/Contents/Home/bin/javac -J-Dfile.encoding=UTF8 "@/var/folders/19/hjm21bn17913_0ck7nh3thdr0000gn/T/tmp546e6a6.tmp" -target 1.7 -source 1.7  (TaskId:187)
    javac: invalid flag: obj/Test (TaskId:187)
    Usage: javac <options> <source files> (TaskId:187)
    use -help for a list of possible options (TaskId:187)

[dellis1972]

still green......