[Mono.Android] Add unsigned NewArray overloads. #4119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
unsigned-fix
branch
2 times, most recently
from
9142658 to
4aa9107
Compare
jpobst
force-pushed
the
unsigned-fix
branch
6 times, most recently
from
58e7c41 to
721bc8b
Compare
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Jan 27, 2020
Fixes: #556 Context: dotnet/android#4119 Call new `JNIEnv.NewArray(...)` overloads that explicitly take unsigned types instead of using the signed counterparts such as `JNIEnv.NewArray((int[])(object)value`. This allows users to get a linker time error if they are using an older Java.Interop.dll that does not support unsigned types, instead of a runtime error.
jonpryor
pushed a commit
to dotnet/java-interop
that referenced
this pull request
Jan 27, 2020
Fixes: #556 Context: dotnet/android#4119 Call new `JNIEnv.NewArray(...)` overloads that explicitly take unsigned types instead of using the signed counterparts such as `JNIEnv.NewArray((int[])(object)value`. This allows users to get a linker time error if they are using an older Java.Interop.dll that does not support unsigned types, instead of a runtime error.
jonpryor
pushed a commit
that referenced
this pull request
Jan 28, 2020
Fixes: dotnet/java-interop#556 Context: dotnet/java-interop@99cf719 Changes: dotnet/java-interop@c0cc770...fc18c54 * dotnet/java-interop@fc18c54: [generator] Call explicit unsigned NewArray() methods (#558) `generator` now requires the use of `JNIEnv.NewArray(X[])` where `X` is an unsigned type -- `uint`, `ushort`, etc. -- in order to support arrays of Kotlin unsigned types. This allows users to get an XA2006 package time error if they are using an older Xamarin.Android that does not support unsigned types, instead of a runtime error. We feel that a packaging-time error will be more reliable and less user-hostile than "random" runtime errors on downlevel product versions.
brendanzagaeski
modified the milestones:
Published: 10.2 (d16-5),
In Preview: 10.3 (d16-6)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/java-interop#558.
Companion JI PR: dotnet/java-interop#558.
Create overloads of
JNIEnv.NewArray (...)that take unsigned arrays as parameters. This allows users to get a package time error if they are using an older Java.Interop.dll that does not support unsigned types instead of a runtime error.