[generator] Call explicit unsigned NewArray methods. (#556) #558
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonpryor
pushed a commit
that referenced
this pull request
Jan 27, 2020
Fixes: #556 Context: dotnet/android#4119 Call new `JNIEnv.NewArray(...)` overloads that explicitly take unsigned types instead of using the signed counterparts such as `JNIEnv.NewArray((int[])(object)value`. This allows users to get a linker time error if they are using an older Java.Interop.dll that does not support unsigned types, instead of a runtime error.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #556
Companion XA PR: dotnet/android#4119
Call new
JNIEnv.NewArray (...)overloads that explicitly take unsigned types instead of doingJNIEnv.NewArray ((int[])(object)value. This allows users to get a linker time error if they are using an older Java.Interop.dll that does not support unsigned types instead of a runtime error.