[xaprepare] Update Android 10 name (#4011) #4185
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://www.blog.google/products/android/evolving-android-brand/
The
AndroidApiInfo.xmlfiles produced byxaprepareduring buildpreparation includes a Name value:
Both the version number and name are shown within various parts of
the IDEs, e.g.
The problem is that starting with Android 10, Google is no longer
providing "nicknames" for Android releases.
What should Visual Studio do?
Currently, we still emit a Name of "Q" for API-29, thus VS shows:
We could "clear out" the Name value, but unfortunately VS currently
doesn't special-case this in any way, and thus would show:
Which looks "wrong".
Fixing this will require two changes:
We (xamarin-android) will begin clearing out the Name for Android
releases which lack a nickname, and
The VS team will modify their Target Framework name generation
logic such that the parenthesis and Name are only used when Name
is a non-empty value. This will allow API-29 to have a displayed
name of
Android 10.0.Begin the process: begin emitting an empty Name field for API-29,
allowing the IDE team to begin implementing their side.