[Xamarin.Android.Build.Tasks] _UpdateAndroidResgen is throwing new APT0000 errors in d15-4 #769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…T0000 errors in d15-4 Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58889 Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58890 Commit 0667a2b and ea6b9b4 added support for short path names. However during the rework we added code to replace `library_project_imports/` with an Empty string. Some of the Nuget Support packages seem to include a `__AndroidLibraryProjects__.zip` which uses windows path sepatators rather than unix ones. So the code to strip off the `library_project_imports/` does not work. We end up with a directory structure like __library_projects__/[dllname]/library_project_imports/library_project_imports which a) does not get picked up by our tasks and b) takes up a bunch of additional characters in our already long path.. The result is the two errors above.. one to do with missing resources the other a PathToLong error. Because the niget packages have already shipped and will be in use, we need to handle BOTH cases.
|
Looks like the macOS+xbuild failure is due to a failure uploading build artifacts to Azure: Merging anyway. |
jonpryor
pushed a commit
to jonpryor/xamarin-android
that referenced
this pull request
Sep 6, 2017
…T0000 errors in d15-4 (dotnet#769) Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58889 Fixes: https://bugzilla.xamarin.com/show_bug.cgi?id=58890 Commit 0667a2b and ea6b9b4 added support for short path names. However during the rework we added code to replace library_project_imports/ with an empty string. Some of the Nuget Support packages seem to include a `__AndroidLibraryProjects__.zip` which uses windows path sepatators rather than unix ones. So the code to strip off the `library_project_imports/` does not work. We end up with a directory structure like __library_projects__/[dllname]/library_project_imports/library_project_imports which a) does not get picked up by our tasks and b) takes up a bunch of additional characters in our already long path.. The result is the two errors above... one to do with missing resources the other a PathToLong error. Because the nuget packages have already shipped and will be in use, we need to handle BOTH cases.
jonpryor
added a commit
to jonpryor/xamarin-android
that referenced
this pull request
Jan 4, 2021
Changes: dotnet/java-interop@2f62ffd...7574f16 * dotnet/java-interop@7574f166: [generator] Add `generator --with-javadoc-xml=FILE` support. (dotnet#687) * dotnet/java-interop@7d197f17: Refactor Crc64 type (dotnet#769) * dotnet/java-interop@876442f4: [generator] Fix MSBuild warning/error format for Visual Studio (dotnet#765) * dotnet/java-interop@3f6cf72b: [.Localization, .Cecil, .Diagnostics, .Generator] $(Nullable)=enable (dotnet#746) dotnet/java-interop#687 was merged.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58889
Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58890
Commit 0667a2b and ea6b9b4 added support for short path names.
However during the rework we added code to replace
with an Empty string. Some of the Nuget Support packages seem
to include a
__AndroidLibraryProjects__.zipwhich useswindows path sepatators rather than unix ones. So the code
to strip off the
library_project_imports/does not work.We end up with a directory structure like
which a) does not get picked up by our tasks and b) takes up
a bunch of additional characters in our already long path..
The result is the two errors above.. one to do with missing resources
the other a PathToLong error.
Because the niget packages have already shipped and will be in use,
we need to handle BOTH cases.