Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xamarin.Android.Build.Tasks] _UpdateAndroidResgen is throwing new APT0000 errors in d15-4 #769

Merged
merged 1 commit into from
Aug 23, 2017

Commits on Aug 22, 2017

  1. [Xamarin.Android.Build.Tasks] _UpdateAndroidResgen is throwing new AP…

    …T0000 errors in d15-4
    
    Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58889
    Fixes https://bugzilla.xamarin.com/show_bug.cgi?id=58890
    
    Commit 0667a2b and ea6b9b4 added support for short path names.
    However during the rework we added code to replace
    
    	`library_project_imports/`
    
    with an Empty string. Some of the Nuget Support packages seem
    to include a `__AndroidLibraryProjects__.zip` which uses
    windows path sepatators rather than unix ones. So the code
    to strip off the `library_project_imports/` does not work.
    We end up with a directory structure like
    
    	__library_projects__/[dllname]/library_project_imports/library_project_imports
    
    which a) does not get picked up by our tasks and b) takes up
    a bunch of additional characters in our already long path..
    
    The result is the two errors above.. one to do with missing resources
    the other a PathToLong error.
    
    Because the niget packages have already shipped and will be in use,
    we need to handle BOTH cases.
    dellis1972 committed Aug 22, 2017
    Configuration menu
    Copy the full SHA
    cf697c8 View commit details
    Browse the repository at this point in the history