More C++ tweaks and changes #9478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
force-pushed
the
dev/grendel/c++23
branch
2 times, most recently
from
cc3f7dd to
8187508
Compare
grendello
force-pushed
the
dev/grendel/c++23
branch
from
8187508 to
14323a1
Compare
grendello
force-pushed
the
dev/grendel/c++23
branch
5 times, most recently
from
88bc1b0 to
614b4aa
Compare
grendello
force-pushed
the
dev/grendel/c++23
branch
2 times, most recently
from
52e7070 to
db9f5f3
Compare
Open
jonpryor
reviewed
Dec 2, 2024
| @@ -603,7 +603,7 @@ Debug::enable_soft_breakpoints (void) | |||
| void* | |||
| xamarin::android::conn_thread (void *arg) | |||
| { | |||
| abort_if_invalid_pointer_argument (arg); | |||
| abort_if_invalid_pointer_argument (arg, "arg"); | |||
There was a problem hiding this comment.
I wonder how meaningful this will be "without context": the abort messages which may be logged to the Google Play Store (594d090) will only contain the message Parameter 'arg' must be a valid pointer. Which "arg"?
I think the parameter should also include the method name in the message. so that a "context free" (no adb logcat) message at least lets us know what function we're talking about:
Parameter 'arg' in function 'conn_thread' must be a valid pointer.
There was a problem hiding this comment.
Implemented in the latest commit
In process to remove object instances for a slightly faster startup
grendello
force-pushed
the
dev/grendel/c++23
branch
from
db9f5f3 to
d9d80ea
Compare
grendello
added a commit
that referenced
this pull request
Dec 5, 2024
* main: [native] More C++ tweaks and changes (#9478) Add android-platform-support to .gitignore (#9590) [ci] Skip JDK install if near match is found in $(JI_JAVA_HOME) (#9585) Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 10653360 (#9587) Revert "Try dependabot max_length param (#9529)" Try dependabot max_length param (#9529) LEGO: Pull request (#9575) Bump to DevDiv/android-platform-support@52dd010a (#9553) Localized file check-in by OneLocBuild Task (#9574)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continued effort to restructure our native C++ runtime, introducing
C++23 features as well as turning as many classes into static ones since
we don't really have objects that need to be created and destroyed during
lifetime of the application:
abort_if*preprocessor macros with templated functions. Thisgives us better type safety. Instead using variadic arguments, we now
provide overloads which take either a plain string without placeholders
or a lambda function to format the message string on demand.
std::string_viewfor literal stringsnoexcept(this is going to be importantonce exceptions are enabled in the future)