Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test dependabot max_length param #9529

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Test dependabot max_length param #9529

merged 1 commit into from
Dec 3, 2024

Conversation

pjcollins
Copy link
Member

No description provided.

@pjcollins
Copy link
Member Author

Don't really have a way of testing this without merging it, but I am not confident it's going to work

@pjcollins pjcollins assigned pjcollins and unassigned pjcollins Dec 3, 2024
@pjcollins pjcollins marked this pull request as ready for review December 3, 2024 18:32
@pjcollins pjcollins requested a review from jonpryor as a code owner December 3, 2024 18:32
jonathanpeppers
jonathanpeppers approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would say we just try it, yeah. 👍

@pjcollins pjcollins merged commit bf2c9e8 into main Dec 3, 2024
58 checks passed
@pjcollins pjcollins deleted the dev/pjc/dep-short-branch branch December 3, 2024 18:40
@pjcollins
Copy link
Member Author

Yeah, I guess we'll have to stick with whatever is officially documented, not sure we can control this for now...

The property '#/updates/1/pull-request-branch-name' contains additional properties ["max_length"] outside of the schema when none are allowed

pjcollins added a commit that referenced this pull request Dec 3, 2024
@pjcollins
Revert "Try dependabot max_length param (#9529)"
e98d20f 
This reverts commit bf2c9e8.
grendello added a commit that referenced this pull request Dec 5, 2024
@grendello
Merge branch 'main' into dev/grendel/use-libc++
6a5ce4c 
* main:
  [native] More C++ tweaks and changes (#9478)
  Add android-platform-support to .gitignore (#9590)
  [ci] Skip JDK install if near match is found in $(JI_JAVA_HOME) (#9585)
  Localized file check-in by OneLocBuild Task: Build definition ID 17928: Build ID 10653360 (#9587)
  Revert "Try dependabot max_length param (#9529)"
  Try dependabot max_length param (#9529)
  LEGO: Pull request (#9575)
  Bump to DevDiv/android-platform-support@52dd010a (#9553)
  Localized file check-in by OneLocBuild Task (#9574)
@github-actions github-actions bot locked and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@jonpryor jonpryor Awaiting requested review from jonpryor jonpryor is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjcollins @jonathanpeppers