Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set default for UseSizeOptimizedLinq #9718

Merged
merged 1 commit into from
Jan 29, 2025
Merged

Set default for UseSizeOptimizedLinq #9718

merged 1 commit into from
Jan 29, 2025

Conversation

MichalStrehovsky
Copy link
Member

Sets the default for switch added in dotnet/sdk#46375.

(Should merge before we start consuming the SDK/runtime that has this.)

@MichalStrehovsky
Set default for UseSizeOptimizedLinq
07c054b 
Sets the default for switch added in dotnet/sdk#46375.

(Should merge before we start consuming the SDK/runtime that has this.)
@MichalStrehovsky MichalStrehovsky mentioned this pull request Jan 28, 2025
Merged
@jonathanpeppers
Copy link
Member

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

jonathanpeppers
jonathanpeppers approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@jonathanpeppers jonathanpeppers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we have a few tests that fail if from a fork:

 Test 'foo' requires a commercial build of .NET for Android.

I'll look into making these ignore instead of fail.

@jonathanpeppers jonathanpeppers merged commit f3ebc6f into dotnet:main Jan 29, 2025
51 of 58 checks passed
grendello added a commit that referenced this pull request Jan 29, 2025
@grendello
Merge branch 'main' into dev/grendel/clr-host
6774e34 
* main:
  [build] remove unused Xamarin.Android files (#9719)
  [illink] Set default for `$(UseSizeOptimizedLinq) (#9718)
@MichalStrehovsky MichalStrehovsky deleted the patch-1 branch January 29, 2025 22:39
@ivanpovazan
Copy link
Member

Just a note that this change makes debug builds slightly bigger as we don't run the trimmer in them.

@dellis1972
Copy link
Contributor

Looks like we have a few tests that fail if from a fork:

 Test 'foo' requires a commercial build of .NET for Android.

I'll look into making these ignore instead of fail.

I did that on purpose. Because there were silently being skipped, and I was doing fast dev changes from a fork and none of the test were running. W

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathanpeppers jonathanpeppers jonathanpeppers approved these changes

@dellis1972 dellis1972 Awaiting requested review from dellis1972 dellis1972 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MichalStrehovsky @jonathanpeppers @ivanpovazan @dellis1972