Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BinLogToSln to enable roll forward #8643

Closed
dougbu opened this issue Mar 17, 2022 · 3 comments
Closed

Update BinLogToSln to enable roll forward #8643

dougbu opened this issue Mar 17, 2022 · 3 comments

Comments

@dougbu
Copy link
Member

dougbu commented Mar 17, 2022

Per discussion in https://teams.microsoft.com/l/message/19:afba3d1545dd45d7b79f34c1821f6055@thread.skype/1647284476328?tenantId=72f988bf-86f1-41af-91ab-2d7cd011db47&groupId=4d73664c-9f2f-450d-82a5-c2f02756606d&parentMessageId=1647284476328&teamName=.NET%20Core%20Eng%20Services%20Partners&channelName=First%20Responders&createdTime=1647284476328, this tool requires a netcoreapp3.1 runtime and will not automatically roll forward. @alexperovich commented in that Teams thread that the tool could be updated to do so and @dsplaisted provided details in dotnet/aspnetcore#40701 (comment). Without this, dotnet/aspnetcore needs to install a runtime that's not used anywhere but for source indexing.

The BinLogToSln tool lives in https://dev.azure.com/dnceng/internal/_git/dotnet-source-indexer?path=/src/SourceBrowser/src/BinLogToSln

@akoeplinger
Copy link
Member

Setting <RollForward>LatestMajor</RollForward> in the .csproj should fix it.

@missymessa
Copy link
Member

I think this was related to Source.Dot.Net, which has been moved to a new owner. Closing.

@dougbu
Copy link
Member Author

dougbu commented Apr 19, 2024

this was related to Arcade's source-indexing features. https://dev.azure.com/dnceng/internal/_git/dotnet-source-indexer?path=/src/SourceBrowser/src/BinLogToSln/BinLogToSln.csproj now enables roll forward (matching @akoeplinger's suggestion). Closing was the right thing to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants