Update EOL versions in `release/6.0` #14621

richlander · 2024-03-19T23:15:41Z

No description provided.

AlitzelMendez · 2024-03-20T20:16:16Z

/azp run

azure-pipelines · 2024-03-20T20:16:25Z

Azure Pipelines successfully started running 1 pipeline(s).

richlander · 2024-03-20T20:51:33Z

Related to #8643

https://github.com/dotnet/source-indexer/blob/main/src/SourceBrowser/src/BinLogToSln/BinLogToSln.csproj

Attemping to remove .NET Core 3.1 usage

arcade/eng/common/templates/job/source-index-stage1.yml

Lines 32 to 38 in b38b7c9

 - task: UseDotNet@2 

 displayName: Use .NET Core sdk 3.1 

 inputs: 

 packageType: sdk 

 version: 3.1.x 

 installationPath: $(Agent.TempDirectory)/dotnet 

 workingDirectory: $(Agent.TempDirectory)

arcade/azure-pipelines-weekly.yaml

Lines 26 to 30 in b38b7c9

 - task: UseDotNet@2 

 displayName: Install .NET 3.1 runtime 

 inputs: 

 packageType: runtime 

 version: 3.1.x

richlander · 2024-03-21T23:50:34Z

We need to update this Ubuntu 14.04 reference.

arcade/azure-pipelines.yml

Line 16 in a4591b2

 image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-cross-0cd4667-20170319080304 

eng/common/templates/jobs/source-build.yml

Co-authored-by: Michael Simons <msimons@microsoft.com>

eng/common/templates-official/jobs/source-build.yml

Co-authored-by: Michael Simons <msimons@microsoft.com>

richlander · 2024-03-22T18:46:00Z

Getting close now. Seems like we have one issue that is this:

                 Std. Error: 
[09:06:40] dbug: Executing command: 'D:\h\w\AC09092B\p\microsoft.dotnet.xharness.cli\6.0.0-prerelease.24154.4\runtimes\any\native\adb\windows\adb.exe  devices -l'
[09:06:40] fail: Error: listing attached devices / emulators: . Check that any emulators have been started, and attached device(s) are connected via USB, powered-on, unlocked and authorized.
[09:06:40] fail: Exception thrown while trying to find compatible device with architecture 'arm64-v8a'
                 System.Exception: One or more attached Android devices are offline or without USB debug permission
                    at Microsoft.DotNet.XHarness.Android.AdbRunner.GetAttachedDevicesWithProperties(String property) in /_/src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs:line 426
                    at Microsoft.DotNet.XHarness.Android.AdbRunner.GetAllDevicesToUse(ILogger logger, IEnumerable`1 apkRequiredProperties, String propertyName) in /_/src/Microsoft.DotNet.XHarness.Android/AdbRunner.cs:line 467
[09:06:40] crit: Failed to find compatible device: arm64-v8a
                 Microsoft.DotNet.XHarness.Common.CLI.NoDeviceFoundException: Failed to find compatible device: arm64-v8a
                    at Microsoft.DotNet.XHarness.CLI.Commands.Android.AndroidInstallCommand.InvokeHelper(ILogger logger, String apkPackageName, String appPackagePath, IEnumerable`1 apkRequiredArchitecture, String deviceId, TimeSpan bootTimeoutSeconds, AdbRunner runner) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/Android/AndroidInstallCommand.cs:line 99
                    at Microsoft.DotNet.XHarness.CLI.Commands.Android.AndroidTestCommand.InvokeInternal(ILogger logger) in /_/src/Microsoft.DotNet.XHarness.CLI/Commands/Android/AndroidTestCommand.cs:line 73
XHarness exit code: 85 (ADB_DEVICE_ENUMERATION_FAILURE)
User command ended with 85

MichaelSimons · 2024-04-02T14:40:01Z

azure-pipelines-pr.yml

@@ -18,7 +18,7 @@ variables:
 resources:
 containers:
 - container: LinuxContainer
- image: mcr.microsoft.com/dotnet-buildtools/prereqs:ubuntu-14.04-cross-0cd4667-20170319080304
+ image: mcr.microsoft.com/dotnet-buildtools/prereqs:centos-7


Why centos-7 versus something newer?

Because we need to avoid breaking compat for .NET 6. CentOS 7 is part of our support contract.

https://github.com/dotnet/core/blob/main/release-notes/6.0/supported-os.md#libc-compatibility

Note that we're continuing to use CentOS 7 for the product build for .NET 6.

Then why change the source-build legs off of centos-7? Additionally CentOS 7 is EOL in June isn't it? What is the plan for the last 5-6 months?

I updated the versions to make them more conservative/consistent.

Plan: status-quo.

MichaelSimons

SB changes LGTM

chcosta · 2024-04-02T21:53:54Z

eng/common/templates-official/job/source-index-stage1.yml

 inputs:
 packageType: sdk
- version: 3.1.x
+ version: 8.0.x


Any reason the 6.0 sdk wouldn't work here? ie, it simplifies things if all the places are using the same sdk where possible...

- task: UseDotNet@2 displayName: Install Correct .NET Version inputs: useGlobalJson: true

It's because (I believe) the global tool has been updated to .NET 8. it was using .NET Core 3.1 so I upgraded the tool to latest, which seemed to make the most sense.

premun · 2024-04-03T11:33:08Z

tests/XHarness.Android.SimulatorTests.proj

@@ -11,7 +11,7 @@
 <XHarnessAndroidProject Include="$(MSBuildThisFileDirectory)XHarness/XHarness.TestApks.proj">
 <AdditionalProperties>XHarnessTestX86=true;XHarnessTestX86_64=true</AdditionalProperties>
 </XHarnessAndroidProject>
- <HelixTargetQueue Include="ubuntu.1804.amd64.android.29.open"/>
+ <HelixTargetQueue Include="ubuntu.2204.amd64.android.29.open"/>


The build failures you're seeing are connected to this change - these are Android emulator tests. I am honestly not sure what's the story with 22.04 and emulators but you could technically leave this at 1804 for now. These are just tests that have more coverage in dotnet/runtime anyway.

I suspect the 32 bit Android emulators are not working well in 22.04. I believe we are not testing on those anymore in runtime anyway.

So alternatively, you can keep 22.04 but remove XHarnessTestX86=true above.

Also we should probably use .svc version of the queues.

Suggested change

<HelixTargetQueue Include="ubuntu.2204.amd64.android.29.open"/>

<HelixTargetQueue Include="ubuntu.1804.amd64.android.29.open"/>

Thanks for that. It looks like the build is now succeeding but I made this proposed change, too. It aligns with others I made.

@jonathanpeppers @Redth -- Do you have insight on Android requirements with ,NET 6?

I can give some context on why we have this in Arcade.

Arcade contains Helix SDK which help .NET repos run tests. A subset of Helix SDK is the XHarness SDK - this allows (mostly runtime) repos to point to a test project and the XHarness SDK builds an apk/app bundle, sends it to Helix, runs the tests on devices, collects results, increases reliability, cleans up after, etc. Basically XHarness SDK is a layer on top of our Apple/Android infrastructure so that as a whole, we provide quite reliable "testing on phones-as-a-service".

The tests that were failing here give us coverage for this functionality as runtime depends on this heavily.
The set of target platforms in these tests probably diverged from what we run in the end repos and is not in any way binding but it covers the basic matrix of simulator/device/OS.

MAUI repos do not use Helix. They use the XHarness tool directly so they don't have this layer.

I propose we just switch back to 1804 for .NET 6. It isn't worth the trouble. We should make sure main and net8 are good.

I switched the XHarness test back to 1804. It seems like XHarness is still failing. Anyone got a guess on that?

8a0f7a4

This seems unrelated?

https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-arcade-refs-pull-14621-merge-fc15ff91104e433f91/System.Buffers.Tests-arm64-v8a-custom-command/1/console.85e9e861.log?helixlogtype=result

@jonathanpeppers

I believe this is just some inherent flakiness of the 6.0 world where the real world phone infra just swept from under the 6.0 branches as literally all of the parts there got updated. So I think re-running the legs a couple of times should get you a green check eventually. I realize this is not ideal but there's just not enough funding to keep the 6.0 world up to date with the everchanging MacOS and Linux versions.

We can also merge over this, I don't think it's a big deal honestly.

richlander · 2024-04-16T14:36:37Z

Looks like the PR is now green. The approvals have expired.

@MichaelSimons @premun

MichaelSimons · 2024-04-16T15:38:04Z

eng/common/templates/job/source-index-stage1.yml

@@ -1,6 +1,6 @@
 parameters:
 runAsPublic: false
- sourceIndexPackageVersion: 1.0.1-20210614.1
+ sourceIndexPackageVersion: 1.0.1-20240320.1


Why was this changed?

Great question. The earlier version of the package was a 3.1 tool. New package is 8.0.

Enabled these changes:

https://github.com/dotnet/arcade/pull/14621/files#diff-9db1a2bc0710670aa4b8fc8741cffefefac50e436fdf599972ff754bbc61c745L38

https://github.com/dotnet/arcade/pull/14621/files#diff-e908527a99e3b88dbe091e1bd3e1791b32c4281941c8bbfa45e2a13d6c02bd9bL30

Apologies, I thought I am the only who can merge this so I did

I don't think you did anything wrong. Michael asked a question and I believe I provided a satisfactory answer. I would say that the source index package version is odd and approximately zero people are paying attention to that. It should be on a checklist for stuff we watch for.

Thanks for the explanation Rich. FYI - I reverted these change in the main PR. 832b3fc before merging as they appeared unrelated and I didn't get a response.

Got it. I did that (for main) so that the branches would match. It doesn't make much sense for the 6.0 branch to have a newer package than main.

We're missing a policy on when this package should be upgraded. The versioning scheme for the package doesn't help much. The forcing function of upgrading the package for this branch was more obvious.

@hoyosjs -- can you offer insight here.

MichaelSimons

Source-build changes LGTM. One question on a non-source-build change.

Update EOL versions

8b8bf20

richlander changed the title ~~Eol-os-6.0~~ Switch to mariner image Mar 19, 2024

build-analysis bot mentioned this pull request Mar 20, 2024

slow macOS - "##[error]The job running on agent Azure Pipelines 9 ran longer than the maximum time of 60 minutes." dotnet/dnceng#1883

Open

3 tasks

Update EOL versions

75c504c

richlander changed the title ~~Switch to mariner image~~ Update EOL versions in release/6.0 Mar 20, 2024

richlander added 3 commits March 20, 2024 14:17

Update package version

c5831a7

Update package version

b75d737

Merge branch 'release/6.0' into eol-os-6.0

7b3f47b

build-analysis bot mentioned this pull request Mar 21, 2024

Cannot find 'arm64-v8a' device dotnet/dnceng#2284

Open

3 tasks

richlander added 3 commits March 21, 2024 16:44

Switch to more conservative versions

689d328

Merge branch 'release/6.0' into eol-os-6.0

95c8d33

Update package version

3f74e1f

MichaelSimons reviewed Mar 22, 2024

View reviewed changes

eng/common/templates/jobs/source-build.yml Outdated Show resolved Hide resolved

richlander and others added 2 commits March 21, 2024 18:14

Update eng/common/templates/jobs/source-build.yml

ed3f74a

Co-authored-by: Michael Simons <msimons@microsoft.com>

Update Android queue

f418906

build-analysis bot mentioned this pull request Mar 22, 2024

Android emulator not booting completely on Helix queue dotnet/dnceng#1448

Open

3 tasks

MichaelSimons reviewed Mar 22, 2024

View reviewed changes

eng/common/templates-official/jobs/source-build.yml Show resolved Hide resolved

Update eng/common/templates-official/jobs/source-build.yml

2efdb92

Co-authored-by: Michael Simons <msimons@microsoft.com>

richlander added 3 commits March 26, 2024 16:29

Update Ubuntu image

f8d5c80

Merge branch 'release/6.0' into eol-os-6.0

424e5de

Merge branch 'release/6.0' into eol-os-6.0

4d4be3f

MichaelSimons reviewed Apr 2, 2024

View reviewed changes

Make versin changes more conservative

dfd730c

MichaelSimons previously approved these changes Apr 2, 2024

View reviewed changes

chcosta reviewed Apr 2, 2024

View reviewed changes

premun reviewed Apr 3, 2024

View reviewed changes

richlander dismissed MichaelSimons’s stale review via 8a0f7a4 April 3, 2024 14:35

Update tests/XHarness.Android.SimulatorTests.proj

8a0f7a4

richlander mentioned this pull request Apr 8, 2024

[WIP] Spec for image use dotnet/dotnet-buildtools-prereqs-docker#997

Open

Merge branch 'release/6.0' into eol-os-6.0

d274d6f

premun approved these changes Apr 16, 2024

View reviewed changes

premun merged commit 532d156 into release/6.0 Apr 16, 2024
15 checks passed

premun deleted the eol-os-6.0 branch April 16, 2024 15:00

MichaelSimons reviewed Apr 16, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update EOL versions in `release/6.0` #14621

Update EOL versions in `release/6.0` #14621

richlander commented Mar 19, 2024 •

edited

Loading

AlitzelMendez commented Mar 20, 2024

azure-pipelines bot commented Mar 20, 2024

richlander commented Mar 20, 2024 •

edited

Loading

richlander commented Mar 21, 2024

richlander commented Mar 22, 2024

MichaelSimons Apr 2, 2024

richlander Apr 2, 2024 •

edited

Loading

MichaelSimons Apr 2, 2024

richlander Apr 2, 2024

MichaelSimons left a comment

chcosta Apr 2, 2024

richlander Apr 2, 2024 •

edited

Loading

premun Apr 3, 2024

premun Apr 3, 2024

richlander Apr 3, 2024

richlander Apr 3, 2024

richlander Apr 3, 2024

premun Apr 9, 2024 •

edited

Loading

richlander Apr 9, 2024

richlander Apr 15, 2024 •

edited

Loading

premun Apr 16, 2024

premun Apr 16, 2024

richlander commented Apr 16, 2024

MichaelSimons Apr 16, 2024

richlander Apr 16, 2024 •

edited

Loading

premun Apr 16, 2024

richlander Apr 16, 2024

MichaelSimons Apr 16, 2024

richlander Apr 16, 2024 •

edited

Loading

MichaelSimons left a comment

	<HelixTargetQueue Include="ubuntu.2204.amd64.android.29.open"/>
	<HelixTargetQueue Include="ubuntu.1804.amd64.android.29.open"/>

Update EOL versions in release/6.0 #14621

Update EOL versions in release/6.0 #14621

Conversation

richlander commented Mar 19, 2024 • edited Loading

AlitzelMendez commented Mar 20, 2024

azure-pipelines bot commented Mar 20, 2024

richlander commented Mar 20, 2024 • edited Loading

richlander commented Mar 21, 2024

richlander commented Mar 22, 2024

Choose a reason for hiding this comment

richlander Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MichaelSimons left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander Apr 2, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

premun Apr 9, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander Apr 15, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander commented Apr 16, 2024

Choose a reason for hiding this comment

richlander Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

richlander Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

MichaelSimons left a comment

Choose a reason for hiding this comment

Update EOL versions in `release/6.0` #14621

Update EOL versions in `release/6.0` #14621

richlander commented Mar 19, 2024 •

edited

Loading

richlander commented Mar 20, 2024 •

edited

Loading

richlander Apr 2, 2024 •

edited

Loading

richlander Apr 2, 2024 •

edited

Loading

premun Apr 9, 2024 •

edited

Loading

richlander Apr 15, 2024 •

edited

Loading

richlander Apr 16, 2024 •

edited

Loading

richlander Apr 16, 2024 •

edited

Loading