Revert "Revert "Remove downlevel runtimes from global.json"" #40701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
area-infrastructure
|
Should work now that we're explicitly restoring 3.1 for this step |
|
Test build worked |
dougbu
approved these changes
Mar 15, 2022
May not be possible for local tools - dotnet/sdk#10375. @marcpopMSFT @dsplaisted is this supported now? |
|
I think dotnet/sdk#10375 was about a command-line option to enable tool roll-forward. We never did that. However, a tool should be able to specify "rollForward": "major" in its runtimeconfig.json file and that should work. |
|
I'm just going to take this as-is then since we're downloading & running the tool in the script |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #40699 & adds an explicit 3.1 restore before trying to use
BinlogToSln